chrome/browser/extensions/api/file_system/file_system_api.h - Issue 306073004: Rename "CheckWritable" to "PrepareForWritableApp" to reflect the actual behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/file_system/file_system_api.h

Issue 306073004: Rename "CheckWritable" to "PrepareForWritableApp" to reflect the actual behavior. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed review comments. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc ('k') | chrome/browser/extensions/api/file_system/file_system_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/file_system/file_system_api.h

diff --git a/chrome/browser/extensions/api/file_system/file_system_api.h b/chrome/browser/extensions/api/file_system/file_system_api.h

index df4e6627f2c76debf11da9543eff6f8c4e7902a2..2fec898460bb2986b750e7ab3c53c45aa5be1edd 100644

--- a/chrome/browser/extensions/api/file_system/file_system_api.h

+++ b/chrome/browser/extensions/api/file_system/file_system_api.h

@@ -53,7 +53,7 @@ class FileSystemEntryFunction : public ChromeAsyncExtensionFunction {

// will ensure the files exist, creating them if necessary, and also check

// that none of the files are links. If it succeeds it proceeds to

// RegisterFileSystemsAndSendResponse, otherwise to HandleWritableFileError.

- void CheckWritableFiles(const std::vector<base::FilePath>& path);

+ void PrepareFilesForWritableApp(const std::vector<base::FilePath>& path);

// This will finish the choose file process. This is either called directly

// from FilesSelected, or from WritableFileChecker. It is called on the UI