Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3035)

Unified Diff: chrome/browser/extensions/api/file_system/file_system_api.cc

Issue 306073004: Rename "CheckWritable" to "PrepareForWritableApp" to reflect the actual behavior. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/file_system/file_system_api.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/file_system/file_system_api.cc
diff --git a/chrome/browser/extensions/api/file_system/file_system_api.cc b/chrome/browser/extensions/api/file_system/file_system_api.cc
index 9200d89533fb2489775a6ef67e8adfc8635a30ae..2cd8ddfc5d4d74428896ce44228d45b56e741fbd 100644
--- a/chrome/browser/extensions/api/file_system/file_system_api.cc
+++ b/chrome/browser/extensions/api/file_system/file_system_api.cc
@@ -283,10 +283,10 @@ FileSystemEntryFunction::FileSystemEntryFunction()
is_directory_(false),
response_(NULL) {}
-void FileSystemEntryFunction::CheckWritableFiles(
+void FileSystemEntryFunction::PrepareFilesForWritableApp(
const std::vector<base::FilePath>& paths) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
- app_file_handler_util::CheckWritableFiles(
+ app_file_handler_util::PrepareFilesForWritableApp(
paths,
GetProfile(),
is_directory_,
@@ -392,7 +392,7 @@ void FileSystemGetWritableEntryFunction::CheckPermissionAndSendResponse() {
}
std::vector<base::FilePath> paths;
paths.push_back(path_);
- CheckWritableFiles(paths);
+ PrepareFilesForWritableApp(paths);
}
void FileSystemGetWritableEntryFunction::SetIsDirectoryOnFileThread() {
@@ -770,7 +770,7 @@ void FileSystemChooseEntryFunction::ConfirmDirectoryAccessOnFileThread(
void FileSystemChooseEntryFunction::OnDirectoryAccessConfirmed(
const std::vector<base::FilePath>& paths) {
if (app_file_handler_util::HasFileSystemWritePermission(extension_)) {
- CheckWritableFiles(paths);
+ PrepareFilesForWritableApp(paths);
return;
}
« no previous file with comments | « chrome/browser/extensions/api/file_system/file_system_api.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698