Simplify threading in browser thread by making only ChromeThread deal with di...

chrome/browser/browser_main.cc

Index: chrome/browser/browser_main.cc
===================================================================
--- chrome/browser/browser_main.cc	(revision 30037)
+++ chrome/browser/browser_main.cc	(working copy)
@@ -164,11 +164,10 @@
   DCHECK_EQ(signal, SIGTERM);
   LOG(WARNING) << "Addressing SIGTERM on " << PlatformThread::CurrentId();
 
-  MessageLoop* main_loop = ChromeThread::GetMessageLoop(ChromeThread::UI);
-  if (main_loop) {
-    // Post the exit task to the main thread.
-    main_loop->PostTask(
-        FROM_HERE, NewRunnableFunction(BrowserList::CloseAllBrowsersAndExit));
+  bool posted = ChromeThread::PostTask(
+      ChromeThread::UI, FROM_HERE,
+      NewRunnableFunction(BrowserList::CloseAllBrowsersAndExit));
+  if (posted) {
     LOG(WARNING) << "Posted task to UI thread; resetting SIGTERM handler";
   }
 
@@ -178,7 +177,7 @@
   term_action.sa_handler = SIG_DFL;
   CHECK(sigaction(SIGTERM, &term_action, NULL) == 0);
 
-  if (!main_loop) {
+  if (!posted) {
     // Without a UI thread to post the exit task to, there aren't many
     // options.  Raise the signal again.  The default handler will pick it up
     // and cause an ungraceful exit.
@@ -331,7 +330,7 @@
   main_message_loop.set_thread_name(thread_name);
 
   // Register the main thread by instantiating it, but don't call any methods.
-  ChromeThread main_thread;
+  ChromeThread main_thread(ChromeThread::UI, MessageLoop::current());
 
   FilePath user_data_dir;
 #if defined(OS_WIN)
@@ -411,6 +410,9 @@
   local_state->RegisterBooleanPref(prefs::kMetricsReportingEnabled,
       GoogleUpdateSettings::GetCollectStatsConsent());
 
+  // Start the database thread (the order doesn't really matter for it).

[darin (slow to review), 2009/10/27 00:06:52]

Q: i'm not sure what the second part means.  the order doesn't really matter for
it??

[jam, 2009/10/27 02:38:18]

I was trying to say that we just need to start the db thread, but it doesn't
matter where in this function we do it.  I'll clarify the comment more.

[darin (slow to review), 2009/10/27 04:43:33]

OK

+  browser_process->db_thread();
+
 #if defined(TOOLKIT_GTK)
   // It is important for this to happen before the first run dialog, as it
   // styles the dialog as well.