Simplify threading in browser thread by making only ChromeThread deal with di...

chrome/browser/autocomplete/search_provider_unittest.cc

Index: chrome/browser/autocomplete/search_provider_unittest.cc
===================================================================
--- chrome/browser/autocomplete/search_provider_unittest.cc	(revision 30037)
+++ chrome/browser/autocomplete/search_provider_unittest.cc	(working copy)
@@ -6,6 +6,7 @@
 #include "base/time.h"
 #include "build/build_config.h"
 #include "chrome/browser/autocomplete/search_provider.h"
+#include "chrome/browser/chrome_thread.h"
 #include "chrome/browser/history/history.h"
 #include "chrome/browser/net/test_url_fetcher_factory.h"
 #include "chrome/browser/search_engines/template_url.h"
@@ -31,7 +32,10 @@
         term1_(L"term1"),
         keyword_t_url_(NULL),
         keyword_term_(L"keyword"),
-        quit_when_done_(false) {}
+        io_thread_(ChromeThread::IO),

[darin (slow to review), 2009/10/27 00:06:52]

does this test thread need to be a real IO thread?  i.e., does it need to have a
MessageLoopForIO allocated on it?

[jam, 2009/10/27 02:38:18]

It already had a MessageLoopForUI before.  I just added the ChromeThread to get
the thread tables the same as the browser process, but ChromeThread doesn't do
anything else.

[jam, 2009/10/27 02:46:29]

oops, I realize what you mean now.  I needed a ChromeThread to get the thread
table, but I don't think the extra MessageLoop will hurt.

[darin (slow to review), 2009/10/27 04:43:33]

OK

+        quit_when_done_(false) {
+    io_thread_.Start();
+  }
 
   // See description above class for what this registers.
   virtual void SetUp();
@@ -62,11 +66,12 @@
   const std::wstring keyword_term_;
   GURL keyword_url_;
 
+  MessageLoopForUI message_loop_;
+  ChromeThread io_thread_;
+
   // URLFetcher::Factory implementation registered.
   TestURLFetcherFactory test_factory_;
 
-  MessageLoopForUI message_loop_;
-
   // Profile we use.
   TestingProfile profile_;