Simplify threading in browser thread by making only ChromeThread deal with di...

chrome/browser/autocomplete/search_provider_unittest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/string_util.h"
 #include "base/time.h"
 #include "build/build_config.h"
 #include "chrome/browser/autocomplete/search_provider.h"
+#include "chrome/browser/chrome_thread.h"
 #include "chrome/browser/history/history.h"
 #include "chrome/browser/net/test_url_fetcher_factory.h"
 #include "chrome/browser/search_engines/template_url.h"
 #include "chrome/browser/search_engines/template_url_model.h"
 #include "chrome/test/testing_profile.h"
 #include "net/url_request/url_request_status.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 // The following environment is configured for these tests:
 // . The TemplateURL default_t_url_ is set as the default provider.
 // . The TemplateURL keyword_t_url_ is added to the TemplateURLModel. This
 //   TemplateURL has a valid suggest and search URL.
 // . The URL created by using the search term term1_ with default_t_url_ is
 //   added to history.
 // . The URL created by using the search term keyword_term_ with keyword_t_url_
 //   is added to history.
 // . test_factory_ is set as the URLFetcher::Factory.
 class SearchProviderTest : public testing::Test,
                            public AutocompleteProvider::ACProviderListener {
  public:
   SearchProviderTest()
       : default_t_url_(NULL),
         term1_(L"term1"),
         keyword_t_url_(NULL),
         keyword_term_(L"keyword"),
-        quit_when_done_(false) {}
+        io_thread_(ChromeThread::IO),

[darin (slow to review), 2009/10/27 00:06:52]

does this test thread need to be a real IO thread?  i.e., does it need to have a
MessageLoopForIO allocated on it?

[jam, 2009/10/27 02:38:18]

It already had a MessageLoopForUI before.  I just added the ChromeThread to get
the thread tables the same as the browser process, but ChromeThread doesn't do
anything else.

[jam, 2009/10/27 02:46:29]

oops, I realize what you mean now.  I needed a ChromeThread to get the thread
table, but I don't think the extra MessageLoop will hurt.

[darin (slow to review), 2009/10/27 04:43:33]

OK

+        quit_when_done_(false) {
+    io_thread_.Start();
+  }
 
   // See description above class for what this registers.
   virtual void SetUp();
 
   virtual void TearDown();
 
  protected:
   // Returns an AutocompleteMatch in provider_'s set of matches that matches
   // |url|. If there is no matching URL, an empty match is returned.
   AutocompleteMatch FindMatchWithDestination(const GURL& url);
@@ skipping 10 matching lines @@
   void QueryForInput(const std::wstring& text);
 
   // See description above class for details of these fields.
   TemplateURL* default_t_url_;
   const std::wstring term1_;
   GURL term1_url_;
   TemplateURL* keyword_t_url_;
   const std::wstring keyword_term_;
   GURL keyword_url_;
 
+  MessageLoopForUI message_loop_;
+  ChromeThread io_thread_;
+
   // URLFetcher::Factory implementation registered.
   TestURLFetcherFactory test_factory_;
 
-  MessageLoopForUI message_loop_;
-
   // Profile we use.
   TestingProfile profile_;
 
   // The provider.
   scoped_refptr<SearchProvider> provider_;
 
   // If true, OnProviderUpdate exits out of the current message loop.
   bool quit_when_done_;
 
   DISALLOW_COPY_AND_ASSIGN(SearchProviderTest);
@@ skipping 172 matching lines @@
   AutocompleteMatch match = FindMatchWithDestination(keyword_url_);
   ASSERT_TRUE(!match.destination_url.is_empty());
 
   // The match should have a TemplateURL.
   EXPECT_TRUE(match.template_url);
 
   // The fill into edit should contain the keyword.
   EXPECT_EQ(keyword_t_url_->keyword() + L" " + keyword_term_,
             match.fill_into_edit);
 }