Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2228)

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab_unittest.cc

Issue 306023011: Add new DialogDelegate for dialogs in the App List (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nit comment Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab_unittest.cc
diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab_unittest.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab_unittest.cc
index 3dded730feb65bf83bfdb660fe49a8f53eea4c92..a7f561b7f75a269a0da6edd6020c9afc90219bf6 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab_unittest.cc
+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab_unittest.cc
@@ -33,7 +33,7 @@ using testing::Eq;
class AppInfoPermissionsTabTest : public testing::Test {
protected:
- AppInfoPermissionsTabTest() : window_(NULL) {};
+ AppInfoPermissionsTabTest() {}
scoped_ptr<base::DictionaryValue> ValidAppManifest() {
return extensions::DictionaryBuilder()
@@ -49,7 +49,6 @@ class AppInfoPermissionsTabTest : public testing::Test {
.Build();
}
- gfx::NativeWindow window_;
TestingProfile profile_;
// We need the UI thread in order to construct UI elements in the view.
@@ -63,7 +62,7 @@ TEST_F(AppInfoPermissionsTabTest, NoPermissionsObtainedCorrectly) {
.SetManifest(ValidAppManifest())
.SetID(kTestExtensionId)
.Build();
- AppInfoPermissionsTab tab(window_, &profile_, app, base::Closure());
+ AppInfoPermissionsTab tab(&profile_, app);
EXPECT_TRUE(tab.GetRequiredPermissions()->IsEmpty());
EXPECT_TRUE(tab.GetRequiredPermissionMessages().empty());
@@ -93,7 +92,7 @@ TEST_F(AppInfoPermissionsTabTest, RequiredPermissionsObtainedCorrectly) {
// a message
.SetID(kTestExtensionId)
.Build();
- AppInfoPermissionsTab tab(window_, &profile_, app, base::Closure());
+ AppInfoPermissionsTab tab(&profile_, app);
const extensions::PermissionSet* required_permissions =
tab.GetRequiredPermissions();
@@ -131,7 +130,7 @@ TEST_F(AppInfoPermissionsTabTest, OptionalPermissionsObtainedCorrectly) {
// a message
.SetID(kTestExtensionId)
.Build();
- AppInfoPermissionsTab tab(window_, &profile_, app, base::Closure());
+ AppInfoPermissionsTab tab(&profile_, app);
const extensions::PermissionSet* optional_permissions =
tab.GetOptionalPermissions();
@@ -164,7 +163,7 @@ TEST_F(AppInfoPermissionsTabTest, RetainedFilePermissionsObtainedCorrectly) {
extensions::ListBuilder().Append("retainEntries")))))
.SetID(kTestExtensionId)
.Build();
- AppInfoPermissionsTab tab(window_, &profile_, app, base::Closure());
+ AppInfoPermissionsTab tab(&profile_, app);
apps::SavedFilesService* files_service =
apps::SavedFilesService::Get(&profile_);

Powered by Google App Engine
This is Rietveld 408576698