chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc - Issue 306023011: Add new DialogDelegate for dialogs in the App List

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc

Issue 306023011: Add new DialogDelegate for dialogs in the App List (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Nit comment Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.h ('k') | chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc

index 9236ebc8d31ead7c2c58cd748d6f3aa18c086472..87034387761390108def70f776a2c63050c19fff 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc

@@ -312,13 +312,9 @@ void ExpandableContainerView::ToggleDetailLevel() {

} // namespace

-AppInfoPermissionsTab::AppInfoPermissionsTab(

- gfx::NativeWindow parent_window,

- Profile* profile,

- const extensions::Extension* app,

- const base::Closure& close_callback)

- : AppInfoTab(parent_window, profile, app, close_callback),

- revoke_file_permissions_button_(NULL) {

+AppInfoPermissionsTab::AppInfoPermissionsTab(Profile* profile,

+ const extensions::Extension* app)

+ : AppInfoTab(profile, app), revoke_file_permissions_button_(NULL) {

this->SetLayoutManager(new views::FillLayout);

// Create a scrollview and add it to the tab.