Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Unified Diff: chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm

Issue 306023011: Add new DialogDelegate for dialogs in the App List (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Made AppInfoDialog a sub-view, and removed a lot of dependencies on close_callback and parent_windo… Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm b/chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm
index 32b352b3bc716349fa6848e8ae953e8a571ea3a9..99b9fa5ca6badcfb282c879b205b3dce1ab6ace1 100644
--- a/chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm
+++ b/chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm
@@ -4,10 +4,8 @@
#include "chrome/browser/ui/apps/app_info_dialog.h"
tapted 2014/06/16 06:11:55 nit: now that a lot of includes are gone, you migh
sashab 2014/06/16 07:01:19 Done.
-void ShowAppInfoDialog(gfx::NativeWindow parent_window,
- const gfx::Rect& dialog_widget_bounds,
+void ShowAppInfoDialog(AppListControllerDelegate* app_list_controller_delegate,
Profile* profile,
- const extensions::Extension* app,
- const base::Closure& close_callback) {
+ const extensions::Extension* app) {
NOTIMPLEMENTED();
}

Powered by Google App Engine
This is Rietveld 408576698