chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm - Issue 306023011: Add new DialogDelegate for dialogs in the App List

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm

Issue 306023011: Add new DialogDelegate for dialogs in the App List (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Made AppInfoDialog a sub-view, and removed a lot of dependencies on close_callback and parent_windo… Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/apps/app_info_dialog.h"	5 #include "chrome/browser/ui/apps/app_info_dialog.h"
	tapted 2014/06/16 06:11:55 nit: now that a lot of includes are gone, you migh nit: now that a lot of includes are gone, you might need to #include base/logging.h for NOTIMPLEMENTED (should do that anyway ) sashab 2014/06/16 07:01:19 Done. Show quoted text On 2014/06/16 06:11:55, tapted wrote: > nit: now that a lot of includes are gone, you might need to #include > base/logging.h for NOTIMPLEMENTED (should do that anyway ) Done.
6	6

7 void ShowAppInfoDialog(gfx::NativeWindow parent_window,	7 void ShowAppInfoDialog(AppListControllerDelegate* app_list_controller_delegate,

8 const gfx::Rect& dialog_widget_bounds,

9 Profile* profile,	8 Profile* profile,

10 const extensions::Extension* app,	9 const extensions::Extension* app) {

11 const base::Closure& close_callback) {

12 NOTIMPLEMENTED();	10 NOTIMPLEMENTED();

13 }	11 }

OLD	NEW