Issue 306023007: Revert 273763 "Add garbage collection for shared extensions on C..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 306023007: Revert 273763 "Add garbage collection for shared extensions on C..." (Closed)

Created:
6 years, 6 months ago by battre

Modified:
6 years, 6 months ago

Reviewers:
Dmitry Polukhin

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 273763 "Add garbage collection for shared extensions on C..." Reverting due to failing memory bots, see http://crbug.com/235263#c42 for details. > Add garbage collection for shared extensions on Chrome OS > > Chrome OS specific garbage collection in addition to profile specific > clean up also cleans up shared location but only once regardless number > of logged in users. > > BUG=235263 > TEST=unittest > > Review URL: https://codereview.chromium.org/303693011 TBR=dpolukhin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273798

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -568 lines)			Patch
M	trunk/src/chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc	View	5 chunks	+6 lines, -7 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/users/fake_user_manager.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/extension_assets_manager_chromeos.h	View	5 chunks	+5 lines, -27 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/extension_assets_manager_chromeos.cc	View	9 chunks	+25 lines, -162 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/extension_garbage_collector.h	View	3 chunks	+16 lines, -6 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/extension_garbage_collector.cc	View	2 chunks	+28 lines, -21 lines	0 comments	Download
D	trunk/src/chrome/browser/extensions/extension_garbage_collector_chromeos.h	View	1 chunk	+0 lines, -53 lines	0 comments	Download
D	trunk/src/chrome/browser/extensions/extension_garbage_collector_chromeos.cc	View	1 chunk	+0 lines, -80 lines	0 comments	Download
D	trunk/src/chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc	View	1 chunk	+0 lines, -196 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/extension_garbage_collector_factory.cc	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	trunk/src/chrome/chrome_browser_extensions.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/chrome_tests_unit.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r273798.