Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 303693011: Add garbage collection for shared extensions on Chrome OS (Closed)

Created:
6 years, 6 months ago by Dmitry Polukhin
Modified:
6 years, 6 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Add garbage collection for shared extensions on Chrome OS Chrome OS specific garbage collection in addition to profile specific clean up also cleans up shared location but only once regardless number of logged in users. BUG=235263 TEST=unittest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273763 R=asargent@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273916

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : comment resolved + rebase #

Patch Set 4 : fixed chromeos compilation #

Patch Set 5 : nit #

Patch Set 6 : fixed Chromium OS valgrind bot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+577 lines, -80 lines) Patch
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/users/fake_user_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_assets_manager_chromeos.h View 1 2 5 chunks +27 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_assets_manager_chromeos.cc View 1 2 3 4 9 chunks +162 lines, -25 lines 0 comments Download
M chrome/browser/extensions/extension_garbage_collector.h View 3 chunks +6 lines, -16 lines 0 comments Download
M chrome/browser/extensions/extension_garbage_collector.cc View 1 2 2 chunks +21 lines, -28 lines 0 comments Download
A chrome/browser/extensions/extension_garbage_collector_chromeos.h View 1 2 3 4 5 1 chunk +57 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_garbage_collector_chromeos.cc View 1 2 3 4 5 1 chunk +85 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc View 1 2 3 4 5 1 chunk +196 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_garbage_collector_factory.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Dmitry Polukhin
This CL depends on https://codereview.chromium.org/273193006
6 years, 6 months ago (2014-05-28 16:21:25 UTC) #1
asargent_no_longer_on_chrome
lgtm https://codereview.chromium.org/303693011/diff/20001/chrome/browser/extensions/extension_assets_manager_chromeos.h File chrome/browser/extensions/extension_assets_manager_chromeos.h (right): https://codereview.chromium.org/303693011/diff/20001/chrome/browser/extensions/extension_assets_manager_chromeos.h#newcode56 chrome/browser/extensions/extension_assets_manager_chromeos.h:56: // extension IDs and version paths that are ...
6 years, 6 months ago (2014-05-29 19:32:00 UTC) #2
Dmitry Polukhin
https://codereview.chromium.org/303693011/diff/20001/chrome/browser/extensions/extension_assets_manager_chromeos.h File chrome/browser/extensions/extension_assets_manager_chromeos.h (right): https://codereview.chromium.org/303693011/diff/20001/chrome/browser/extensions/extension_assets_manager_chromeos.h#newcode56 chrome/browser/extensions/extension_assets_manager_chromeos.h:56: // extension IDs and version paths that are in ...
6 years, 6 months ago (2014-05-29 22:38:37 UTC) #3
Dmitry Polukhin
The CQ bit was checked by dpolukhin@chromium.org
6 years, 6 months ago (2014-05-29 23:31:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/303693011/60001
6 years, 6 months ago (2014-05-29 23:32:31 UTC) #5
Dmitry Polukhin
The CQ bit was unchecked by dpolukhin@chromium.org
6 years, 6 months ago (2014-05-30 00:12:00 UTC) #6
Dmitry Polukhin
The CQ bit was checked by dpolukhin@chromium.org
6 years, 6 months ago (2014-05-30 00:39:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/303693011/80001
6 years, 6 months ago (2014-05-30 00:40:10 UTC) #8
commit-bot: I haz the power
Change committed as 273763
6 years, 6 months ago (2014-05-30 08:14:55 UTC) #9
Dmitry Polukhin
6 years, 6 months ago (2014-05-30 22:38:05 UTC) #10
Message was sent while issue was closed. 
Committed patchset #6 manually as r273916 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698