Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: tools/valgrind/vbug205541.patch

Issue 306020: Update valgrind to fix one problem with 64 bit code, and a regression running... Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/valgrind/vbug205541.patch
===================================================================
--- tools/valgrind/vbug205541.patch (Revision 0)
+++ tools/valgrind/vbug205541.patch (Revision 0)
@@ -0,0 +1,21 @@
+# See https://bugs.kde.org/show_bug.cgi?id=205541#c1
+Index: memcheck/mc_main.c
+===================================================================
+--- memcheck/mc_main.c (revision 10877)
Timur Iskhodzhanov 2009/10/21 09:33:28 why not 10880?
++++ memcheck/mc_main.c (working copy)
+@@ -3708,7 +3708,14 @@
+ if (rr || ww || xx)
+ MC_(make_mem_defined)(a, len);
+ else
+- MC_(make_mem_noaccess)(a, len);
++ MC_(make_mem_defined)(a, len);
Timur Iskhodzhanov 2009/10/21 09:33:28 In this case the condition above doesn't make sens
++ /* State after mmap(,,PROT_NONE,,,) should match
++ * state after mprotect(,,PROT_NONE): the operating system
++ * will trap any access, but any subsequent mprotect(,,PROT_R|W|X)
++ * will re-instate the previous V bits [in this case, all valid].
++ * See comment in mc_pre_clo_init() re:
++ * VG_(track_change_mem_mprotect) ( NULL );
++ */
+ }
+
+ static

Powered by Google App Engine
This is Rietveld 408576698