Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: tools/valgrind/vbug210481.patch

Issue 306020: Update valgrind to fix one problem with 64 bit code, and a regression running... Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/valgrind/vbug205541.patch ('K') | « tools/valgrind/vbug205541.patch ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/vbug210481.patch
===================================================================
--- tools/valgrind/vbug210481.patch (Revision 0)
+++ tools/valgrind/vbug210481.patch (Revision 0)
@@ -0,0 +1,14 @@
+# See https://bugs.kde.org/show_bug.cgi?id=210481
+Index: guest_amd64_toIR.c
+===================================================================
+--- VEX/priv/guest_amd64_toIR.c (Revision 1924)
Timur Iskhodzhanov 2009/10/21 09:33:28 why not 1913?
++++ VEX/priv/guest_amd64_toIR.c (Arbeitskopie)
+@@ -14597,7 +14597,7 @@
+ /* There is no encoding for 32-bit pop in 64-bit mode.
+ So sz==4 actually means sz==8. */
+ if (haveF2orF3(pfx)) goto decode_failure;
+- vassert(sz == 2 || sz == 4);
++ vassert(sz == 2 || sz == 4 || sz == 8);
+ if (sz == 4) sz = 8;
+ if (sz != 8) goto decode_failure; // until we know a sz==2 test case exists
+
« tools/valgrind/vbug205541.patch ('K') | « tools/valgrind/vbug205541.patch ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698