Issue 306013010: allow subpixel positioning w/ bitmap filtering

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 306013010: allow subpixel positioning w/ bitmap filtering

Created:
6 years, 6 months ago by reed1

Modified:
6 years, 5 months ago

Reviewers:
humper, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

allow subpixel positioning w/ bitmap filtering BUG=skia:

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -31 lines)			Patch
M	src/core/SkBitmapProcState.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/core/SkBitmapProcState.cpp	View		7 chunks	+33 lines, -21 lines	0 comments	Download
M	src/core/SkBitmapProcState_matrixProcs.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkDraw.cpp	View	1 2 3	2 chunks	+18 lines, -6 lines	0 comments	Download
M	src/core/SkMatrix.cpp	View		3 chunks	+30 lines, -0 lines	0 comments	Download
M	src/core/SkMatrixUtils.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/DrawBitmapRectTest.cpp	View		4 chunks	+44 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

reed1

6 years, 6 months ago (2014-06-05 00:58:53 UTC) #1

not completely right, but this is getting there (for all filters except High,
which will need a follow-up CL to expand the cache-key to take X,Y offsets I
think)

Expand Messages | Collapse Messages