Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: ipc/ipc_channel_handle_acceptor.h

Issue 305973002: Rename IPC::ChannelFactory to ChannelHandleAcceptor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing GN build Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_channel_factory.cc ('k') | ipc/ipc_channel_handle_acceptor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel_handle_acceptor.h
diff --git a/ipc/ipc_channel_factory.h b/ipc/ipc_channel_handle_acceptor.h
similarity index 63%
rename from ipc/ipc_channel_factory.h
rename to ipc/ipc_channel_handle_acceptor.h
index 3115601b4917e55f43e75bed27e3d6797514d482..2c1db6f3095b819b0f1d646a04d5cb4d687661cd 100644
--- a/ipc/ipc_channel_factory.h
+++ b/ipc/ipc_channel_handle_acceptor.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef IPC_IPC_CHANNEL_FACTORY_H_
-#define IPC_IPC_CHANNEL_FACTORY_H_
+#ifndef IPC_IPC_CHANNEL_HANDLE_ACCEPTOR_H_
+#define IPC_IPC_CHANNEL_HANDLE_ACCEPTOR_H_
#include "base/files/file_path.h"
#include "base/message_loop/message_loop.h"
@@ -12,11 +12,12 @@
namespace IPC {
-// A ChannelFactory listens on a UNIX domain socket. When a client connects to
-// the socket, it accept()s the connection and passes the new FD to the
-// delegate. The delegate is then responsible for creating a new IPC::Channel
-// for the FD.
-class IPC_EXPORT ChannelFactory : public base::MessageLoopForIO::Watcher {
+// A ChannelHandleAcceptor listens on a UNIX domain socket. When a
darin (slow to review) 2014/05/29 23:57:48 This comment makes this sound very UNIX domain soc
+// client connects to the socket, it accept()s the connection and
+// passes the new FD to the delegate. The delegate is then responsible
+// for creating a new IPC::Channel for the FD.
+class IPC_EXPORT ChannelHandleAcceptor
+ : public base::MessageLoopForIO::Watcher {
public:
class Delegate {
public:
@@ -29,9 +30,9 @@ class IPC_EXPORT ChannelFactory : public base::MessageLoopForIO::Watcher {
virtual void OnListenError() = 0;
};
- ChannelFactory(const base::FilePath& path, Delegate* delegate);
+ ChannelHandleAcceptor(const base::FilePath& path, Delegate* delegate);
- virtual ~ChannelFactory();
+ virtual ~ChannelHandleAcceptor();
// Call this to start listening on the socket.
bool Listen();
@@ -45,14 +46,14 @@ class IPC_EXPORT ChannelFactory : public base::MessageLoopForIO::Watcher {
virtual void OnFileCanWriteWithoutBlocking(int fd) OVERRIDE;
base::MessageLoopForIO::FileDescriptorWatcher
- server_listen_connection_watcher_;
+ server_listen_connection_watcher_;
base::FilePath path_;
Delegate* delegate_;
int listen_fd_;
- DISALLOW_COPY_AND_ASSIGN(ChannelFactory);
+ DISALLOW_COPY_AND_ASSIGN(ChannelHandleAcceptor);
};
} // namespace IPC
-#endif // IPC_IPC_CHANNEL_FACTORY_H_
+#endif // IPC_IPC_CHANNEL_HANDLE_ACCEPTOR_H_
« no previous file with comments | « ipc/ipc_channel_factory.cc ('k') | ipc/ipc_channel_handle_acceptor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698