Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: ipc/ipc_channel_handle_acceptor.h

Issue 305973002: Rename IPC::ChannelFactory to ChannelHandleAcceptor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing GN build Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ipc/ipc_channel_factory.cc ('k') | ipc/ipc_channel_handle_acceptor.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IPC_IPC_CHANNEL_FACTORY_H_ 5 #ifndef IPC_IPC_CHANNEL_HANDLE_ACCEPTOR_H_
6 #define IPC_IPC_CHANNEL_FACTORY_H_ 6 #define IPC_IPC_CHANNEL_HANDLE_ACCEPTOR_H_
7 7
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "ipc/ipc_channel_handle.h" 10 #include "ipc/ipc_channel_handle.h"
11 #include "ipc/ipc_export.h" 11 #include "ipc/ipc_export.h"
12 12
13 namespace IPC { 13 namespace IPC {
14 14
15 // A ChannelFactory listens on a UNIX domain socket. When a client connects to 15 // A ChannelHandleAcceptor listens on a UNIX domain socket. When a
darin (slow to review) 2014/05/29 23:57:48 This comment makes this sound very UNIX domain soc
16 // the socket, it accept()s the connection and passes the new FD to the 16 // client connects to the socket, it accept()s the connection and
17 // delegate. The delegate is then responsible for creating a new IPC::Channel 17 // passes the new FD to the delegate. The delegate is then responsible
18 // for the FD. 18 // for creating a new IPC::Channel for the FD.
19 class IPC_EXPORT ChannelFactory : public base::MessageLoopForIO::Watcher { 19 class IPC_EXPORT ChannelHandleAcceptor
20 : public base::MessageLoopForIO::Watcher {
20 public: 21 public:
21 class Delegate { 22 class Delegate {
22 public: 23 public:
23 // Called when a client connects to the factory. It is the delegate's 24 // Called when a client connects to the factory. It is the delegate's
24 // responsibility to create an IPC::Channel for the handle, or else close 25 // responsibility to create an IPC::Channel for the handle, or else close
25 // the file descriptor contained therein. 26 // the file descriptor contained therein.
26 virtual void OnClientConnected(const ChannelHandle& handle) = 0; 27 virtual void OnClientConnected(const ChannelHandle& handle) = 0;
27 28
28 // Called when an error occurs and the channel is closed. 29 // Called when an error occurs and the channel is closed.
29 virtual void OnListenError() = 0; 30 virtual void OnListenError() = 0;
30 }; 31 };
31 32
32 ChannelFactory(const base::FilePath& path, Delegate* delegate); 33 ChannelHandleAcceptor(const base::FilePath& path, Delegate* delegate);
33 34
34 virtual ~ChannelFactory(); 35 virtual ~ChannelHandleAcceptor();
35 36
36 // Call this to start listening on the socket. 37 // Call this to start listening on the socket.
37 bool Listen(); 38 bool Listen();
38 39
39 // Close and unlink the socket, and stop accepting connections. 40 // Close and unlink the socket, and stop accepting connections.
40 void Close(); 41 void Close();
41 42
42 private: 43 private:
43 bool CreateSocket(); 44 bool CreateSocket();
44 virtual void OnFileCanReadWithoutBlocking(int fd) OVERRIDE; 45 virtual void OnFileCanReadWithoutBlocking(int fd) OVERRIDE;
45 virtual void OnFileCanWriteWithoutBlocking(int fd) OVERRIDE; 46 virtual void OnFileCanWriteWithoutBlocking(int fd) OVERRIDE;
46 47
47 base::MessageLoopForIO::FileDescriptorWatcher 48 base::MessageLoopForIO::FileDescriptorWatcher
48 server_listen_connection_watcher_; 49 server_listen_connection_watcher_;
49 base::FilePath path_; 50 base::FilePath path_;
50 Delegate* delegate_; 51 Delegate* delegate_;
51 int listen_fd_; 52 int listen_fd_;
52 53
53 DISALLOW_COPY_AND_ASSIGN(ChannelFactory); 54 DISALLOW_COPY_AND_ASSIGN(ChannelHandleAcceptor);
54 }; 55 };
55 56
56 } // namespace IPC 57 } // namespace IPC
57 58
58 #endif // IPC_IPC_CHANNEL_FACTORY_H_ 59 #endif // IPC_IPC_CHANNEL_HANDLE_ACCEPTOR_H_
OLDNEW
« no previous file with comments | « ipc/ipc_channel_factory.cc ('k') | ipc/ipc_channel_handle_acceptor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698