Rename IPC::ChannelFactory to ChannelHandleAcceptor.

Rename IPC::ChannelFactory to UnixDomainSocketAcceptor.

ChannelFactory doesn't create any channel and it just listens on
and accepts from a unix socket. So this change renames it to
represent what it actually does.

R=darin@chromium.org,cpu@chromium.org,jeremya@chromium.org,tapted@chromium.org
TEST=none
BUG=377980
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284231

[Hajime Morrita, 2014-05-29 17:03:59]

PTAL?

Trent: Could you rubberstamp this for apps/ please?
The rename touches these files.

[jeremya, 2014-05-29 19:44:53]

On 2014/05/29 17:03:59, morrita wrote:
> PTAL?
> 
> Trent: Could you rubberstamp this for apps/ please?
> The rename touches these files.

lgtm, this name was confusing. It even says in the comments that the delegate is
responsible for creating the channel :)

[Scott Hess - ex-Googler, 2014-05-29 20:25:59]

lgtm

[Not sure why I was added.  Factor was a terrible name, the new name is ...
well, it's not great, either, but I'm not thinking of a better name offhand, and
listen sockets are gnarly in the first place.]

[tapted, 2014-05-29 23:02:29]

apps/app_shim lgtm - thanks!

[Hajime Morrita, 2014-05-29 23:19:05]

Thanks for reviewing folks!
Still need a rubberstamp from ipc/ OWNERs.

[darin (slow to review), 2014-05-29 23:57:48]

https://codereview.chromium.org/305973002/diff/20001/ipc/ipc_channel_handle_a...
File ipc/ipc_channel_handle_acceptor.h (right):

https://codereview.chromium.org/305973002/diff/20001/ipc/ipc_channel_handle_a...
ipc/ipc_channel_handle_acceptor.h:15: // A ChannelHandleAcceptor listens on a
UNIX domain socket. When a
This comment makes this sound very UNIX domain socket specific. I see that this
is only used on Mac too. Maybe the name should be more specific?
UnixDomainSocketListener?

[Hajime Morrita, 2014-05-30 16:51:14]

Darin: PTAL? Updated to follow the suggestion.
 
>
https://codereview.chromium.org/305973002/diff/20001/ipc/ipc_channel_handle_a...
> ipc/ipc_channel_handle_acceptor.h:15: // A ChannelHandleAcceptor listens on a
> UNIX domain socket. When a
> This comment makes this sound very UNIX domain socket specific. I see that
this
> is only used on Mac too. Maybe the name should be more specific?
> UnixDomainSocketListener?
Makes sense. Renamed to UnixDomainSocketAcceptor. "Listener" sounds something
like Delegate to me.

[Hajime Morrita, 2014-06-03 16:34:49]

Darin: ping? Just a rename.

[darin (slow to review), 2014-07-17 21:41:56]

LGTM

(You might want to fixup the title of this issue.)

Note: it seems like this class could move to the app_shim folder too. it isn't
needed by anything else, so it doesn't need to live in a generic location.

[Hajime Morrita, 2014-07-17 22:22:58]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-07-17 22:26:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/morrita@chromium.org/305973002/70001

[Hajime Morrita, 2014-07-17 22:43:25]

The CQ bit was unchecked by morrita@chromium.org

[Hajime Morrita, 2014-07-17 22:43:26]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-07-17 22:43:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/morrita@chromium.org/305973002/70001

[Hajime Morrita, 2014-07-18 00:18:11]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-07-18 00:20:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/morrita@chromium.org/305973002/90001

[commit-bot: I haz the power, 2014-07-18 02:53:48]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/30147)

[commit-bot: I haz the power, 2014-07-18 03:16:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 03:16:30]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/30156)

[Hajime Morrita, 2014-07-18 17:32:23]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-07-18 17:33:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/morrita@chromium.org/305973002/100001

[Hajime Morrita, 2014-07-18 19:56:56]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-07-18 19:57:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/morrita@chromium.org/305973002/120001

[commit-bot: I haz the power, 2014-07-18 22:44:14]

Change committed as 284231