Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 305963012: Revert 273825 "Tentatively enable StartupBrowserCreatorFirstRunT..." (Closed)

Created:
6 years, 6 months ago by marja
Modified:
6 years, 6 months ago
Reviewers:
marja
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 273825 "Tentatively enable StartupBrowserCreatorFirstRunT..." Reason: the tests still fail. > Tentatively enable StartupBrowserCreatorFirstRunTest.* on official Mac builder. > > I recently fixed some places which passed empty URLs around (r272182), and these > tests might have been failing because of the empty URL behavior (empty URLs were > treated as the home page, and maybe the home page is something different on the > official Mac builder than other builders). > > Feel free to revert this commit if the tests fail. > > R=bartfab@chromium.org > TBR=sky@chromium.org > BUG=314819 > > Review URL: https://codereview.chromium.org/308083004 TBR=marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274262

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -8 lines) Patch
M trunk/src/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 8 chunks +66 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
marja
6 years, 6 months ago (2014-06-02 16:55:47 UTC) #1
marja
6 years, 6 months ago (2014-06-02 16:55:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r274262.

Powered by Google App Engine
This is Rietveld 408576698