Issue 308083004: Tentatively enable StartupBrowserCreatorFirstRunTest.* on official Mac builder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 308083004: Tentatively enable StartupBrowserCreatorFirstRunTest.* on official Mac builder. (Closed)

Created:
6 years, 6 months ago by marja

Modified:
6 years, 6 months ago

Reviewers:
bartfab (slow), sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Tentatively enable StartupBrowserCreatorFirstRunTest.* on official Mac builder. I recently fixed some places which passed empty URLs around (r272182), and these tests might have been failing because of the empty URL behavior (empty URLs were treated as the home page, and maybe the home page is something different on the official Mac builder than other builders). Feel free to revert this commit if the tests fail. R=bartfab@chromium.org TBR=sky@chromium.org BUG=314819 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273825

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -66 lines)			Patch
	M	chrome/browser/ui/startup/startup_browser_creator_browsertest.cc	View		8 chunks	+8 lines, -66 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/308083004/1

6 years, 6 months ago (2014-05-30 12:15:28 UTC) #4

Message was sent while issue was closed.

Change committed as 273825

Expand Messages | Collapse Messages