Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1380)

Unified Diff: Source/core/svg/animation/SVGSMILElement.h

Issue 305783004: Prepare SVGSMILElement for oilpan (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/animation/SVGSMILElement.h
diff --git a/Source/core/svg/animation/SVGSMILElement.h b/Source/core/svg/animation/SVGSMILElement.h
index 53ebec950bebd863e9a9c4dde21b276e9636d607..1056ddf2a3e4b3514e61f89137337584707d188e 100644
--- a/Source/core/svg/animation/SVGSMILElement.h
+++ b/Source/core/svg/animation/SVGSMILElement.h
@@ -186,8 +186,8 @@ private:
String name() const { return m_name; }
SMILTime offset() const { return m_offset; }
int repeat() const { return m_repeat; }
- Element* syncBase() const { return m_syncBase.get(); }
- void setSyncBase(Element* element) { m_syncBase = element; }
+ SVGSMILElement* syncBase() const { return m_syncBase.get(); }
+ void setSyncBase(SVGSMILElement* element) { m_syncBase = element; }
ConditionEventListener* eventListener() const { return m_eventListener.get(); }
void setEventListener(PassRefPtr<ConditionEventListener>);
@@ -198,7 +198,7 @@ private:
String m_name;
SMILTime m_offset;
int m_repeat;
- RefPtrWillBeMember<Element> m_syncBase;
+ RefPtrWillBeWeakMember<SVGSMILElement> m_syncBase;
haraken 2014/05/29 04:58:58 It looks strange that RefPtr becomes WeakMember. S
kouhei (in TOK) 2014/05/29 05:08:10 syncBase was manually unregistered via d-tor, howe
haraken 2014/05/29 06:14:10 Even if "X was manually unregistered via d-tor", i
RefPtr<ConditionEventListener> m_eventListener;
};
bool parseCondition(const String&, BeginOrEnd beginOrEnd);
@@ -236,7 +236,7 @@ private:
bool m_isWaitingForFirstInterval;
- typedef WillBeHeapHashSet<RawPtrWillBeMember<SVGSMILElement> > TimeDependentSet;
+ typedef WillBeHeapHashSet<RawPtrWillBeWeakMember<SVGSMILElement> > TimeDependentSet;
TimeDependentSet m_syncBaseDependents;
// Instance time lists
« no previous file with comments | « no previous file | Source/core/svg/animation/SVGSMILElement.cpp » ('j') | Source/core/svg/animation/SVGSMILElement.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698