Prepare SVGSMILElement for oilpan

Source/core/svg/animation/SVGSMILElement.h

 /*
  * Copyright (C) 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 168 matching lines @@
         }
         ~Condition();
         void trace(Visitor*);
 
         Type type() const { return m_type; }
         BeginOrEnd beginOrEnd() const { return m_beginOrEnd; }
         String baseID() const { return m_baseID; }
         String name() const { return m_name; }
         SMILTime offset() const { return m_offset; }
         int repeat() const { return m_repeat; }
-        Element* syncBase() const { return m_syncBase.get(); }
-        void setSyncBase(Element* element) { m_syncBase = element; }
+        SVGSMILElement* syncBase() const { return m_syncBase.get(); }
+        void setSyncBase(SVGSMILElement* element) { m_syncBase = element; }
         ConditionEventListener* eventListener() const { return m_eventListener.get(); }
         void setEventListener(PassRefPtr<ConditionEventListener>);
 
     private:
         Type m_type;
         BeginOrEnd m_beginOrEnd;
         String m_baseID;
         String m_name;
         SMILTime m_offset;
         int m_repeat;
-        RefPtrWillBeMember<Element> m_syncBase;
+        RefPtrWillBeWeakMember<SVGSMILElement> m_syncBase;

[haraken, 2014/05/29 04:58:58]

It looks strange that RefPtr becomes WeakMember. Shouldn't the Condition and the
SVGSMILElement live & die together? In what situation do we want to let the
Condition outlive the SVGSMILElement?

[kouhei (in TOK), 2014/05/29 05:08:10]

syncBase was manually unregistered via d-tor, however we are removing this in
oilpan builds, so this need to be weak.

[haraken, 2014/05/29 06:14:10]

Even if "X was manually unregistered via d-tor", it doesn't necessarily mean
that we want to make it weak. It's possible that the pointer was a back pointer
(not a weak pointer) and thus was manually unregistered when X died.

The point is whether the Condition and the SVGSMILElement should die together or
not. So I want to understand in what situation we want to let the Condition
outlive the SVGSMILElement.

         RefPtr<ConditionEventListener> m_eventListener;
     };
     bool parseCondition(const String&, BeginOrEnd beginOrEnd);
     void parseBeginOrEnd(const String&, BeginOrEnd beginOrEnd);
     SVGElement* eventBaseFor(const Condition&);
 
     void disconnectSyncBaseConditions();
     void disconnectEventBaseConditions();
 
     // Event base timing
@@ skipping 17 matching lines @@
     SMILTime calculateNextProgressTime(SMILTime elapsed) const;
 
     RawPtrWillBeMember<SVGElement> m_targetElement;
 
     WillBeHeapVector<OwnPtrWillBeMember<Condition> > m_conditions;
     bool m_syncBaseConditionsConnected;
     bool m_hasEndEventConditions;
 
     bool m_isWaitingForFirstInterval;
 
-    typedef WillBeHeapHashSet<RawPtrWillBeMember<SVGSMILElement> > TimeDependentSet;
+    typedef WillBeHeapHashSet<RawPtrWillBeWeakMember<SVGSMILElement> > TimeDependentSet;
     TimeDependentSet m_syncBaseDependents;
 
     // Instance time lists
     Vector<SMILTimeWithOrigin> m_beginTimes;
     Vector<SMILTimeWithOrigin> m_endTimes;
 
     // This is the upcoming or current interval
     SMILTime m_intervalBegin;
     SMILTime m_intervalEnd;
 
@@ skipping 23 matching lines @@
 {
     return node.hasTagName(SVGNames::setTag) || node.hasTagName(SVGNames::animateTag) || node.hasTagName(SVGNames::animateMotionTag)
         || node.hasTagName(SVGNames::animateTransformTag) || node.hasTagName((SVGNames::discardTag));
 }
 
 DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(SVGSMILElement);
 
 }
 
 #endif // SVGSMILElement_h