Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: Source/core/events/EventFactory.h

Issue 305723002: Use method registration approach for creating events on core and modules. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebaseline Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Document.idl ('k') | Source/modules/EventModulesFactory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/events/EventFactory.h
diff --git a/Source/core/events/EventFactory.h b/Source/core/events/EventFactory.h
index fae23e9e1a7f895e5ffb2d7a2f3349f56efb3b64..78f7be1869a60a7998f61bf87d599d185b67f46d 100644
--- a/Source/core/events/EventFactory.h
+++ b/Source/core/events/EventFactory.h
@@ -34,9 +34,14 @@ namespace WebCore {
class Event;
-class EventFactory {
+class EventFactoryBase {
public:
- static PassRefPtrWillBeRawPtr<Event> create(const String& eventType);
+ virtual PassRefPtrWillBeRawPtr<Event> create(const String& eventType) = 0;
+};
+
+class EventFactory : public EventFactoryBase {
+public:
+ virtual PassRefPtrWillBeRawPtr<Event> create(const String& eventType) OVERRIDE;
};
}
« no previous file with comments | « Source/core/dom/Document.idl ('k') | Source/modules/EventModulesFactory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698