Source/core/dom/Document.idl - Issue 305723002: Use method registration approach for creating events on core and modules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.idl

Issue 305723002: Use method registration approach for creating events on core and modules. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebaseline Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Document.idl

diff --git a/Source/core/dom/Document.idl b/Source/core/dom/Document.idl

index 796ef26480ca1d8d1e6f7b53a78b99bdb3305a91..30fbc26e4c37d7d4e92040a9830b26089d9dff74 100644

--- a/Source/core/dom/Document.idl

+++ b/Source/core/dom/Document.idl

@@ -63,9 +63,7 @@ typedef (CanvasRenderingContext2D or WebGLRenderingContext) RenderingContext;

// DOM Level 2 Events (DocumentEvents interface)

- // Customize createEvent so it can call createEventModules in modules.

- // FIXME: Use method registration approach instead. http://crbug.com/358074

- [Custom, RaisesException] Event createEvent(DOMString eventType);

+ [RaisesException] Event createEvent(DOMString eventType);

// DOM Level 2 Traversal and Range (DocumentRange interface)

« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/events/EventFactory.h » ('j') | no next file with comments »