Convert wstring/wchar_t* in chrome/renderer to std::string/char* or string16.

Convert wstring/wchar_t* in chrome/renderer to std::string/char* or string16.

These were (mostly) made possible by the change in DictionaryValue's keys to
std::string.

BUG=23581
TEST=unit tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54483

[viettrungluu, 2010-07-31 19:43:43]

Or maybe I should send this to foo_; he seems qualified.

[Evan Martin, 2010-07-31 23:16:01]

I wonder if the API shouldn't just be "SetString()" rather than with UTF16 in
there -- it's obvious from the type that it's a string16.

LGTM in any case

[viettrungluu, 2010-07-31 23:18:54]

On 2010/07/31 23:16:01, Evan Martin wrote:
> I wonder if the API shouldn't just be "SetString()" rather than with UTF16 in
> there -- it's obvious from the type that it's a string16.
> 
> LGTM in any case

Yeah, I thought about that. I'm following existing precedent (in values.h) for
now, though I reserve the right to change my mind later. (Clearly I'm just
guaranteeing work for myself.)

Thanks.

[brettw, 2010-07-31 23:38:00]

On Sat, Jul 31, 2010 at 4:16 PM,  <evan@chromium.org> wrote:
> I wonder if the API shouldn't just be "SetString()" rather than with UTF16
> in
> there -- it's obvious from the type that it's a string16.

I do think it should be SetString. I think the only reason we ended up
with "UTF16" in various places was to differentiate it from the old
wide code.

Brett

[viettrungluu, 2010-07-31 23:48:07]

On 2010/07/31 23:38:00, brettw wrote:
> On Sat, Jul 31, 2010 at 4:16 PM,  <mailto:evan@chromium.org> wrote:
> > I wonder if the API shouldn't just be "SetString()" rather than with UTF16
> > in
> > there -- it's obvious from the type that it's a string16.
> 
> I do think it should be SetString. I think the only reason we ended up
> with "UTF16" in various places was to differentiate it from the old
> wide code.

Okay, I'll change that. I guess the same applies to the other "UTF16" methods in
values.h (e.g., CreateStringValueFromUTF16, GetAsUTF16, etc.)?

[brettw, 2010-07-31 23:52:46]

On Sat, Jul 31, 2010 at 4:48 PM,  <viettrungluu@chromium.org> wrote:
> On 2010/07/31 23:38:00, brettw wrote:
>>
>> On Sat, Jul 31, 2010 at 4:16 PM,  <mailto:evan@chromium.org> wrote:
>> > I wonder if the API shouldn't just be "SetString()" rather than with
>> > UTF16
>> > in
>> > there -- it's obvious from the type that it's a string16.
>
>> I do think it should be SetString. I think the only reason we ended up
>> with "UTF16" in various places was to differentiate it from the old
>> wide code.
>
> Okay, I'll change that. I guess the same applies to the other "UTF16"
> methods in
> values.h (e.g., CreateStringValueFromUTF16, GetAsUTF16, etc.)?

Yes, generally these should be "String". If we need to support UTF-8
and UTF-16 generally we use "String" and "String16" to tell them apart
(in code I consider to be good examples of this).

Brett