Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: chrome/renderer/extensions/extension_process_bindings.cc

Issue 3057027: Convert wstring/wchar_t* in chrome/renderer to std::string/char* or string16. (Closed)
Patch Set: utf8 -> utf16 for things coming from resources Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/extension_process_bindings.cc
diff --git a/chrome/renderer/extensions/extension_process_bindings.cc b/chrome/renderer/extensions/extension_process_bindings.cc
index 828aabc04b64c8d56517af9e62ec1e9b8754fbe5..8057e674a34dadc8e2390274218851f16b4ff752 100644
--- a/chrome/renderer/extensions/extension_process_bindings.cc
+++ b/chrome/renderer/extensions/extension_process_bindings.cc
@@ -295,7 +295,7 @@ class ExtensionImpl : public ExtensionBase {
if (viewtype_to_find != ViewType::EXTENSION_POPUP &&
viewtype_to_find != ViewType::EXTENSION_TOOLSTRIP) {
- NOTREACHED() << L"Requesting invalid view type.";
+ NOTREACHED() << "Requesting invalid view type.";
}
// Disallow searching for a host view if we are a popup view, and likewise
@@ -527,10 +527,10 @@ class ExtensionImpl : public ExtensionBase {
static_cast<const char*>(bitmap_pickle.data()), bitmap_pickle.size());
DictionaryValue* dict = new DictionaryValue();
- dict->Set(L"imageData", bitmap_value);
+ dict->Set("imageData", bitmap_value);
if (details->Has(v8::String::New("tabId"))) {
- dict->SetInteger(L"tabId",
+ dict->SetInteger("tabId",
details->Get(v8::String::New("tabId"))->Int32Value());
}
« no previous file with comments | « chrome/renderer/extensions/extension_api_json_validity_unittest.cc ('k') | chrome/renderer/localized_error.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698