Reducing code duplication between WGC3D(InProcess)CommandBufferImpl

Reducing code duplication between WGC3D(InProcess)CommandBufferImpl

Currently any time a new GL function is added both classes need to be updated
with identical code. This patch moves the shared portion of the code into a
common location.

R=piman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273598

[bajones, 2014-05-27 23:23:46]

This is a quick pass at cleaning up some of the code duplication between the two
classes. I think ultimately we'd like fully merge the two implementations into
one, but that seems to have a few additional complications. This seemed like a
good intermediate step.

There may be some philosophical objections to the new class name
(WebGraphicsContext3DImpl) since it's not a full implementation of
WebGraphicsContext3D. (It does make it easier for developers to connect the
dots, though.) I'm happy to change that to any other suggested name.

[piman, 2014-05-28 11:02:12]

lgtm

[bajones, 2014-05-28 16:26:24]

The CQ bit was checked by bajones@chromium.org

[commit-bot: I haz the power, 2014-05-28 16:27:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bajones@chromium.org/305643004/1

[commit-bot: I haz the power, 2014-05-28 21:05:26]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/10078)

[commit-bot: I haz the power, 2014-05-28 21:20:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-28 21:20:08]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[bajones, 2014-05-28 21:55:05]

The CQ bit was checked by bajones@chromium.org

[commit-bot: I haz the power, 2014-05-28 21:56:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bajones@chromium.org/305643004/20001

[commit-bot: I haz the power, 2014-05-29 01:21:32]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[commit-bot: I haz the power, 2014-05-29 01:36:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-29 01:36:57]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[bajones, 2014-05-29 17:29:17]

The CQ bit was checked by bajones@chromium.org

[commit-bot: I haz the power, 2014-05-29 17:32:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bajones@chromium.org/305643004/40001

[commit-bot: I haz the power, 2014-05-29 21:17:56]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[bajones, 2014-05-29 21:20:33]

Committed patchset #3 manually as r273598 (presubmit successful).

[jamesr, 2014-06-03 21:22:56]

https://codereview.chromium.org/305643004/diff/40001/webkit/common/gpu/webgra...
File webkit/common/gpu/webgraphicscontext3d_impl.h (right):

https://codereview.chromium.org/305643004/diff/40001/webkit/common/gpu/webgra...
webkit/common/gpu/webgraphicscontext3d_impl.h:40: namespace content {
what on earth? why are we defining symbols in namespace content:: inside
webkit/common/gpu ?

[bajones, 2014-06-03 21:25:13]

https://codereview.chromium.org/305643004/diff/40001/webkit/common/gpu/webgra...
File webkit/common/gpu/webgraphicscontext3d_impl.h (right):

https://codereview.chromium.org/305643004/diff/40001/webkit/common/gpu/webgra...
webkit/common/gpu/webgraphicscontext3d_impl.h:40: namespace content {
On 2014/06/03 21:22:56, jamesr wrote:
> what on earth? why are we defining symbols in namespace content:: inside
> webkit/common/gpu ?

Ack! That's a mistake. (File was originally a copy of
webgraphicscontext3d_command_buffer_impl.h)

I'll upload fix ASAP. Thanks for spotting it!