Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 305513004: Cleanup GetPropertyWithCallback / SetPropertyWithCallback API (Closed)

Created:
6 years, 7 months ago by Toon Verwaest
Modified:
6 years, 6 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Cleanup GetPropertyWithCallback / SetPropertyWithCallback API BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21555

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -153 lines) Patch
M src/objects.h View 3 chunks +17 lines, -21 lines 0 comments Download
M src/objects.cc View 11 chunks +119 lines, -126 lines 0 comments Download
M src/runtime.cc View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 7 months ago (2014-05-27 14:10:52 UTC) #1
Igor Sheludko
lgtm
6 years, 7 months ago (2014-05-27 15:29:52 UTC) #2
Toon Verwaest
6 years, 6 months ago (2014-05-28 09:29:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21555 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698