Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Unified Diff: src/runtime.cc

Issue 305513004: Cleanup GetPropertyWithCallback / SetPropertyWithCallback API (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index 0bff90b8c0bac865eef8a2544679140e6bbe8202..d260eb935bb9be5fdb8541250ccbd8dea6f9acb0 100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -5189,12 +5189,9 @@ RUNTIME_FUNCTION(Runtime_DefineOrRedefineDataProperty) {
Handle<Object> result_object;
ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
isolate, result_object,
- JSObject::SetPropertyWithCallback(js_object,
- callback,
- name,
- obj_value,
+ JSObject::SetPropertyWithCallback(js_object, name, obj_value,
handle(lookup.holder()),
- STRICT));
+ callback, STRICT));
return *result_object;
}
}
@@ -10790,7 +10787,7 @@ static Handle<Object> DebugLookupResultValue(Isolate* isolate,
ASSERT(!structure->IsForeign());
if (structure->IsAccessorInfo()) {
MaybeHandle<Object> obj = JSObject::GetPropertyWithCallback(
- handle(result->holder(), isolate), receiver, structure, name);
+ receiver, name, handle(result->holder(), isolate), structure);
if (!obj.ToHandle(&value)) {
value = handle(isolate->pending_exception(), isolate);
isolate->clear_pending_exception();
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698