remove SkBitmap::asImageInfo

remove SkBitmap::asImageInfo

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14909

[scroggo, 2014-05-27 18:42:23]

https://codereview.chromium.org/305483005/diff/1/include/core/SkBitmap.h
File include/core/SkBitmap.h (left):

https://codereview.chromium.org/305483005/diff/1/include/core/SkBitmap.h#oldc...
include/core/SkBitmap.h:330: bool asImageInfo(SkImageInfo* info) const {
I support the change, but we're not quite ready for this. It appears webkit
still uses this:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Android also uses it:
https://cs.corp.google.com/#android/frameworks/base/core/jni/android/graphics...

[hal.canary, 2014-05-27 18:48:45]

On 2014/05/27 18:42:23, scroggo wrote:
> https://codereview.chromium.org/305483005/diff/1/include/core/SkBitmap.h
> File include/core/SkBitmap.h (left):
> 
>
https://codereview.chromium.org/305483005/diff/1/include/core/SkBitmap.h#oldc...
> include/core/SkBitmap.h:330: bool asImageInfo(SkImageInfo* info) const {
> I support the change, but we're not quite ready for this. It appears webkit
> still uses this:
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> 
> Android also uses it:
>
https://cs.corp.google.com/#android/frameworks/base/core/jni/android/graphics...


Given that, you can go ahead and remove Skia's use of it and mark it as
deprecated.

[reed1, 2014-05-27 19:48:41]

ptal

https://codereview.chromium.org/305483005/diff/1/include/core/SkBitmap.h
File include/core/SkBitmap.h (left):

https://codereview.chromium.org/305483005/diff/1/include/core/SkBitmap.h#oldc...
include/core/SkBitmap.h:330: bool asImageInfo(SkImageInfo* info) const {
On 2014/05/27 18:42:23, scroggo wrote:
> I support the change, but we're not quite ready for this. It appears webkit
> still uses this:
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> 
> Android also uses it:
>
https://cs.corp.google.com/#android/frameworks/base/core/jni/android/graphics...

Moved behind a guard.

[scroggo, 2014-05-27 19:59:20]

https://codereview.chromium.org/305483005/diff/40001/gyp/skia_for_chromium_de...
File gyp/skia_for_chromium_defines.gypi (right):

https://codereview.chromium.org/305483005/diff/40001/gyp/skia_for_chromium_de...
gyp/skia_for_chromium_defines.gypi:17: 'SK_SUPPORT_LEGACY_ASIMAGEINFO',
This also needs to be in gyp/common_conditions.gypi for skia_android_framework,
unless you wait until
https://googleplex-android-review.git.corp.google.com/#/c/473195/ lands.

[scroggo, 2014-05-27 20:43:25]

lgtm

https://codereview.chromium.org/305483005/diff/40001/gyp/skia_for_chromium_de...
File gyp/skia_for_chromium_defines.gypi (right):

https://codereview.chromium.org/305483005/diff/40001/gyp/skia_for_chromium_de...
gyp/skia_for_chromium_defines.gypi:17: 'SK_SUPPORT_LEGACY_ASIMAGEINFO',
On 2014/05/27 19:59:20, scroggo wrote:
> This also needs to be in gyp/common_conditions.gypi for
skia_android_framework,
> unless you wait until
> https://googleplex-android-review.git.corp.google.com/#/c/473195/ lands.

That CL has landed.

[reed1, 2014-05-27 21:08:55]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-05-27 21:09:15]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/reed@google.com/305483005/40001

[commit-bot: I haz the power, 2014-05-27 21:13:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Build-Mac10.8-Clang-x86-Release-Trybot on tryserver.chromium
(http://108.170.220.76:10117/builders/Build-Mac10.8-Clang-x86-Release-Trybot/b...)
  Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on tryserver.chromium
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-...)

[commit-bot: I haz the power, 2014-05-27 21:18:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-27 21:18:46]

Try jobs failed on following builders:
  Build-Mac10.8-Clang-x86-Release-Trybot on tryserver.chromium
(http://108.170.220.76:10117/builders/Build-Mac10.8-Clang-x86-Release-Trybot/b...)

[reed1, 2014-05-27 21:22:53]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-05-27 21:23:21]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/reed@google.com/305483005/60001

[commit-bot: I haz the power, 2014-05-27 21:30:42]

Change committed as 14909