Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/image/SkImage.cpp

Issue 305483005: remove SkBitmap::asImageInfo (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/core/SkImageFilter.cpp ('k') | src/image/SkImagePriv.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 Google Inc. 2 * Copyright 2012 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkBitmap.h" 8 #include "SkBitmap.h"
9 #include "SkCanvas.h" 9 #include "SkCanvas.h"
10 #include "SkImagePriv.h" 10 #include "SkImagePriv.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 return true; 96 return true;
97 case kAlpha_8_SkColorType: 97 case kAlpha_8_SkColorType:
98 return true; 98 return true;
99 default: 99 default:
100 break; 100 break;
101 } 101 }
102 return false; 102 return false;
103 } 103 }
104 104
105 bool SkImage_Base::onReadPixels(SkBitmap* bitmap, const SkIRect& subset) const { 105 bool SkImage_Base::onReadPixels(SkBitmap* bitmap, const SkIRect& subset) const {
106 SkImageInfo info;
107
108 if (bitmap->pixelRef()) { 106 if (bitmap->pixelRef()) {
109 if (!bitmap->asImageInfo(&info)) { 107 const SkImageInfo info = bitmap->info();
108 if (kUnknown_SkColorType == info.colorType()) {
110 return false; 109 return false;
111 } 110 }
112 if (!raster_canvas_supports(info)) { 111 if (!raster_canvas_supports(info)) {
113 return false; 112 return false;
114 } 113 }
115 } else { 114 } else {
116 SkImageInfo info = SkImageInfo::MakeN32Premul(subset.width(), 115 const SkImageInfo info = SkImageInfo::MakeN32Premul(subset.width(), subs et.height());
117 subset.height());
118 SkBitmap tmp; 116 SkBitmap tmp;
119 if (!tmp.allocPixels(info)) { 117 if (!tmp.allocPixels(info)) {
120 return false; 118 return false;
121 } 119 }
122 *bitmap = tmp; 120 *bitmap = tmp;
123 } 121 }
124 122
125 SkRect srcR, dstR; 123 SkRect srcR, dstR;
126 srcR.set(subset); 124 srcR.set(subset);
127 dstR = srcR; 125 dstR = srcR;
128 dstR.offset(-dstR.left(), -dstR.top()); 126 dstR.offset(-dstR.left(), -dstR.top());
129 127
130 SkCanvas canvas(*bitmap); 128 SkCanvas canvas(*bitmap);
131 129
132 SkPaint paint; 130 SkPaint paint;
133 paint.setXfermodeMode(SkXfermode::kClear_Mode); 131 paint.setXfermodeMode(SkXfermode::kClear_Mode);
134 canvas.drawRect(dstR, paint); 132 canvas.drawRect(dstR, paint);
135 133
136 const_cast<SkImage_Base*>(this)->onDrawRectToRect(&canvas, &srcR, dstR, NULL ); 134 const_cast<SkImage_Base*>(this)->onDrawRectToRect(&canvas, &srcR, dstR, NULL );
137 return true; 135 return true;
138 } 136 }
OLDNEW
« no previous file with comments | « src/core/SkImageFilter.cpp ('k') | src/image/SkImagePriv.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698