Issue 305433002: Experimental app list slide animation is now horizontal, not vertical.

Issue 305433002: Experimental app list slide animation is now horizontal, not vertical. (Closed)

Created:
6 years, 7 months ago by Matt Giuca

Modified:
6 years, 7 months ago

Reviewers:
benwells, calamity

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Experimental app list slide animation is now horizontal, not vertical. This makes the lack of proper clipping of WebContents more noticeable, but it's behind a flag so fixing it isn't urgent. Note that the animation always slides pages to/from the left side (previously the top). In the future, the pages will be positioned in the correct order. BUG=376068 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272945

Patch Set 1 #

Patch Set 2 : Clip AppsGridView to avoid off-screen icons drawing over the start screen. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	ui/app_list/views/apps_grid_view.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	ui/app_list/views/contents_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Matt Giuca

Oh wait, I can't commit this until I hide all app list grid pages that ...

6 years, 7 months ago (2014-05-26 23:56:33 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/305433002/40001

6 years, 7 months ago (2014-05-27 05:15:22 UTC) #7

Message was sent while issue was closed.

Change committed as 272945

Expand Messages | Collapse Messages