ui/app_list/views/apps_grid_view.cc - Issue 305433002: Experimental app list slide animation is now horizontal, not vertical.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/views/apps_grid_view.cc

Issue 305433002: Experimental app list slide animation is now horizontal, not vertical. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Clip AppsGridView to avoid off-screen icons drawing over the start screen. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/app_list/views/apps_grid_view.cc

diff --git a/ui/app_list/views/apps_grid_view.cc b/ui/app_list/views/apps_grid_view.cc

index ea4829ab9e60b236adb42a163e290a882c471698..2f088ae233ef7f0af9c6efe87f617ca3cd0d2aca 100644

--- a/ui/app_list/views/apps_grid_view.cc

+++ b/ui/app_list/views/apps_grid_view.cc

@@ -358,6 +358,9 @@ AppsGridView::AppsGridView(AppsGridViewDelegate* delegate,

activated_folder_item_view_(NULL),

dragging_for_reparent_item_(false) {

SetPaintToLayer(true);

+ // Clip any icons that are outside the grid view's bounds. These icons would

+ // otherwise be visible to the user when the grid view is off screen.

+ layer()->SetMasksToBounds(true);

SetFillsBoundsOpaquely(false);

pagination_model_->AddObserver(this);

« no previous file with comments | « no previous file | ui/app_list/views/contents_view.cc » ('j') | no next file with comments »