Issue 305423002: Limited number of buildsets that can be used to initialize RietveldPollerWithCache's cache

Issue 305423002: Limited number of buildsets that can be used to initialize RietveldPollerWithCache's cache (Closed)

Created:
6 years, 6 months ago by Sergiy Byelozyorov

Modified:
6 years, 6 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build

Visibility:
Public.

More Reviews

Description

Limited number of buildsets that can be used to initialize RietveldPollerWithCache's cache Depends on https://codereview.chromium.org/302283005/ BUG=160709 R=phajdan.jr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=274428

Patch Set 2 : Correct comment #

Total comments: 2

Patch Set 3 : Review + corrected test behavior #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -21 lines)			Patch
	M	scripts/master/try_job_rietveld.py	View	1 2	3 chunks	+12 lines, -6 lines	0 comments	Download
	M	scripts/master/unittests/try_job_rietveld_test.py	View	1 2	4 chunks	+17 lines, -15 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

Sergiy Byelozyorov

ignore this one for now, requires Buildbot 0.8.8, we use Buildbot 0.8.4p4

6 years, 6 months ago (2014-06-02 16:43:22 UTC) #3

Sergiy Byelozyorov

PTAL, this should work after https://codereview.chromium.org/302283005/ is commited

6 years, 6 months ago (2014-06-02 21:40:30 UTC) #4

Paweł Hajdan Jr.

LGTM with a comment https://codereview.chromium.org/305423002/diff/20001/scripts/master/try_job_rietveld.py File scripts/master/try_job_rietveld.py (right): https://codereview.chromium.org/305423002/diff/20001/scripts/master/try_job_rietveld.py#newcode248 scripts/master/try_job_rietveld.py:248: # Get recent BuildBot buildsets. ...

6 years, 6 months ago (2014-06-03 08:08:47 UTC) #5

Sergiy Byelozyorov

https://codereview.chromium.org/305423002/diff/20001/scripts/master/try_job_rietveld.py File scripts/master/try_job_rietveld.py (right): https://codereview.chromium.org/305423002/diff/20001/scripts/master/try_job_rietveld.py#newcode248 scripts/master/try_job_rietveld.py:248: # Get recent BuildBot buildsets. On 2014/06/03 08:08:47, Paweł ...

6 years, 6 months ago (2014-06-03 08:20:00 UTC) #6

Sergiy Byelozyorov

The CQ bit was checked by sergiyb@chromium.org

6 years, 6 months ago (2014-06-03 08:23:07 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergiyb@chromium.org/305423002/60001

6 years, 6 months ago (2014-06-03 08:23:46 UTC) #9

Message was sent while issue was closed.

Change committed as 274428

Expand Messages | Collapse Messages