Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1367)

Issue 302283005: Backported getRecentBuildsets from buildbot 0.8.8 (to use it in RietveldPollerWithCache) (Closed)

Created:
6 years, 6 months ago by Sergiy Byelozyorov
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : Added diff to the README.chromium #

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -0 lines) Patch
M third_party/buildbot_8_4p1/README.chromium View 1 2 3 1 chunk +142 lines, -0 lines 0 comments Download
M third_party/buildbot_8_4p1/buildbot/db/buildsets.py View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/buildbot_8_4p1/buildbot/test/unit/test_db_buildsets.py View 1 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sergiy Byelozyorov
6 years, 6 months ago (2014-06-02 21:34:23 UTC) #1
Sergey Berezin
LGTM + comments (though you may need someone else's stamp, maybe stip@ or phajdan.jr@). Please ...
6 years, 6 months ago (2014-06-03 00:48:10 UTC) #2
Sergiy Byelozyorov
On 2014/06/03 00:48:10, Sergey Berezin wrote: > LGTM + comments (though you may need someone ...
6 years, 6 months ago (2014-06-03 07:09:52 UTC) #3
Paweł Hajdan Jr.
LGTM The risk seems to be negligible, we only add new methods here and do ...
6 years, 6 months ago (2014-06-03 08:07:20 UTC) #4
Sergiy Byelozyorov
The CQ bit was checked by sergiyb@chromium.org
6 years, 6 months ago (2014-06-03 08:07:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergiyb@chromium.org/302283005/60001
6 years, 6 months ago (2014-06-03 08:08:13 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 08:08:41 UTC) #7
Message was sent while issue was closed.
Change committed as 274427

Powered by Google App Engine
This is Rietveld 408576698