Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 305383002: Do not set touch region on PageOverlay layer. (Closed)

Created:
6 years, 6 months ago by dgozman
Modified:
6 years, 6 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Do not set touch region on PageOverlay layer. With new touch hit testing in compositor, which looks through all the layers hitting the point, we don't need touch regions on overlay layer anymore. Note, that we still need main-thread scrolling to stay in sync with page contents. BUG=304271 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175578

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M LayoutTests/fast/events/touch/compositor-touch-hit-rects-global-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PageOverlay.cpp View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
dgozman
Could you please take a look?
6 years, 6 months ago (2014-06-02 10:04:50 UTC) #1
Rick Byers
lgtm, thanks!
6 years, 6 months ago (2014-06-02 18:43:14 UTC) #2
dgozman
jochen@, could you please approve?
6 years, 6 months ago (2014-06-04 07:48:40 UTC) #3
pfeldman
lgtm
6 years, 6 months ago (2014-06-05 12:32:38 UTC) #4
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 6 months ago (2014-06-05 12:32:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/305383002/1
6 years, 6 months ago (2014-06-05 12:33:08 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-05 14:07:09 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 14:42:03 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10435)
6 years, 6 months ago (2014-06-05 14:42:03 UTC) #9
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 6 months ago (2014-06-05 14:45:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/305383002/1
6 years, 6 months ago (2014-06-05 14:45:56 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 15:21:09 UTC) #12
Message was sent while issue was closed.
Change committed as 175578

Powered by Google App Engine
This is Rietveld 408576698