Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2757)

Unified Diff: Source/web/PageOverlay.cpp

Issue 305383002: Do not set touch region on PageOverlay layer. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/events/touch/compositor-touch-hit-rects-global-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/PageOverlay.cpp
diff --git a/Source/web/PageOverlay.cpp b/Source/web/PageOverlay.cpp
index 06d7816425147671f587554b619a75d749e02441..6a1e59826a924949c26116ad9f3866d73f740c01 100644
--- a/Source/web/PageOverlay.cpp
+++ b/Source/web/PageOverlay.cpp
@@ -122,14 +122,9 @@ void PageOverlay::update()
if (WebCore::Page* page = m_viewImpl->page())
page->inspectorController().willAddPageOverlay(m_layer.get());
- // Compositor hit-testing does not know how to deal with layers that may be
- // transparent to events (see http://crbug.com/269598). So require
- // scrolling and touches on this layer to go to the main thread.
+ // This is required for contents of overlay to stay in sync with the page while scrolling.
WebLayer* platformLayer = m_layer->platformLayer();
platformLayer->setShouldScrollOnMainThread(true);
- WebVector<WebRect> webRects(static_cast<size_t>(1));
- webRects[0] = WebRect(0, 0, INT_MAX, INT_MAX);
- platformLayer->setTouchEventHandlerRegion(webRects);
}
FloatSize size(m_viewImpl->size());
« no previous file with comments | « LayoutTests/fast/events/touch/compositor-touch-hit-rects-global-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698