Issue 3053010: Show an error update engine status for all unknown states.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3053010: Show an error update engine status for all unknown states. (Closed)

Created:
10 years, 5 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
Sean Parent

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org, adlr

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Show an error update engine status for all unknown states. The primary reason for this patch is so that I can add a new UPDATE_STATUS enum value to libcros without breaking the Chrome OS build with the following error: "Right now we get the following error with LKGR of Chrome: update_observer.cc: In member function 'virtual void chromeos::UpdateObserver::Changed(chromeos::UpdateLibrary*)': update_observer.cc:26: error: enumeration value 'UPDATE_STATUS_REPORTING_ERROR_EVENT' not handled in switch" BUG=560 TEST=emerged chromeos-chrome with modified libcros, unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53409

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	chrome/browser/chromeos/update_observer.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages