Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4544)

Unified Diff: chrome/browser/chromeos/update_observer.cc

Issue 3053010: Show an error update engine status for all unknown states. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/update_observer.cc
diff --git a/chrome/browser/chromeos/update_observer.cc b/chrome/browser/chromeos/update_observer.cc
index ac1af569746d0b1debbd282cfd2f5cb00dd74f5e..56c919e5322b1f68ca0aa8b8cf47d33687c0e95e 100644
--- a/chrome/browser/chromeos/update_observer.cc
+++ b/chrome/browser/chromeos/update_observer.cc
@@ -24,9 +24,6 @@ UpdateObserver::~UpdateObserver() {
void UpdateObserver::Changed(UpdateLibrary* object) {
switch (object->status().status) {
- case UPDATE_STATUS_ERROR:
- notification_.Show(l10n_util::GetStringUTF16(IDS_UPDATE_ERROR), true);
- break;
case UPDATE_STATUS_IDLE:
case UPDATE_STATUS_CHECKING_FOR_UPDATE:
// Do nothing in these cases, we don't want to notify the user of the
@@ -59,8 +56,10 @@ void UpdateObserver::Changed(UpdateLibrary* object) {
case UPDATE_STATUS_UPDATED_NEED_REBOOT:
notification_.Show(l10n_util::GetStringUTF16(IDS_UPDATE_COMPLETED), true);
break;
+ default:
+ notification_.Show(l10n_util::GetStringUTF16(IDS_UPDATE_ERROR), true);
+ break;
}
}
} // namespace chromeos
-
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698