chrome/browser/ui/browser_command_controller.cc - Issue 305243002: Replace usage of GetActiveEntry with GetLastCommittedEntry in chrome/browser/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 305243002: Replace usage of GetActiveEntry with GetLastCommittedEntry in chrome/browser/ui. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixes based on pkasting's review. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser_command_controller.cc

diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc

index d036d1646e193cfda39830f38b0b25968329f406..d03dd599cb59d74c24889403d2f5014ad7313657 100644

--- a/chrome/browser/ui/browser_command_controller.cc

+++ b/chrome/browser/ui/browser_command_controller.cc

@@ -1100,7 +1100,7 @@ void BrowserCommandController::UpdateCommandsForTabState() {

// Changing the encoding is not possible on Chrome-internal webpages.

NavigationController& nc = current_web_contents->GetController();

- bool is_chrome_internal = HasInternalURL(nc.GetActiveEntry()) ||

+ bool is_chrome_internal = HasInternalURL(nc.GetLastCommittedEntry()) ||

current_web_contents->ShowingInterstitialPage();

command_updater_.UpdateCommandEnabled(IDC_ENCODING_MENU,

!is_chrome_internal && current_web_contents->IsSavable());

« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »