chrome/browser/ui/browser_browsertest.cc - Issue 305243002: Replace usage of GetActiveEntry with GetLastCommittedEntry in chrome/browser/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 305243002: Replace usage of GetActiveEntry with GetLastCommittedEntry in chrome/browser/ui. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixes based on pkasting's review. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser_browsertest.cc

diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc

index 094aec15d9978df549e0dd7c74cb5f4c62c2d82f..e7541f0f5ec8e46290fc089f4dd6b1c0e6fa7ee6 100644

--- a/chrome/browser/ui/browser_browsertest.cc

+++ b/chrome/browser/ui/browser_browsertest.cc

@@ -1238,7 +1238,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest,

ui_test_utils::NavigateToURL(browser(), url);

NavigationEntry* entry = browser()->tab_strip_model()->

- GetActiveWebContents()->GetController().GetActiveEntry();

+ GetActiveWebContents()->GetController().GetLastCommittedEntry();

EXPECT_EQ(expected_favicon_url.spec(), entry->GetFavicon().url.spec());

}

@@ -1258,7 +1258,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, MAYBE_FaviconChange) {

ui_test_utils::NavigateToURL(browser(), file_url);

NavigationEntry* entry = browser()->tab_strip_model()->

- GetActiveWebContents()->GetController().GetActiveEntry();

+ GetActiveWebContents()->GetController().GetLastCommittedEntry();

static const base::FilePath::CharType* kIcon =

FILE_PATH_LITERAL("test1.png");

GURL expected_favicon_url(ui_test_utils::GetTestUrl(base::FilePath(

« no previous file with comments | « no previous file | chrome/browser/ui/browser_command_controller.cc » ('j') | no next file with comments »