Replace usage of GetActiveEntry with GetLastCommittedEntry in chrome/browser/ui.

Replace usage of GetActiveEntry with GetLastCommittedEntry in chrome/browser/ui.

BUG=273710
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274442

[nasko, 2014-06-02 18:13:29]

Hi Peter,
Can you review this CL for me?
Thanks in advance!
Nasko

[Peter Kasting, 2014-06-02 18:38:58]

LGTM

https://codereview.chromium.org/305243002/diff/1/chrome/browser/ui/browser_co...
File chrome/browser/ui/browser_commands.cc (right):

https://codereview.chromium.org/305243002/diff/1/chrome/browser/ui/browser_co...
chrome/browser/ui/browser_commands.cc:316: NavigationEntry* active_entry =
Nit: Update this variable name

https://codereview.chromium.org/305243002/diff/1/chrome/browser/ui/browser_co...
chrome/browser/ui/browser_commands.cc:318: // See comment in
UpdateCommandsForTabState about why we call url().
Nit: While here: "url()" no longer seems to exist, is this referring to
GetURL()?

https://codereview.chromium.org/305243002/diff/1/chrome/browser/ui/browser_co...
chrome/browser/ui/browser_commands.cc:1083: return
current_tab->GetController().GetLastCommittedEntry() != NULL;
Nit: Simpler:

  return current_tab && current_tab->GetController().GetLastCommittedEntry();

https://codereview.chromium.org/305243002/diff/1/chrome/browser/ui/browser_co...
chrome/browser/ui/browser_commands.cc:1158: // active entry in
view_source_contents will be the last committed entry.
This comment seems like it can be removed.

https://codereview.chromium.org/305243002/diff/1/chrome/browser/ui/browser_co...
chrome/browser/ui/browser_commands.cc:1162: NavigationEntry* active_entry =
Nit: Update this variable name.

[nasko, 2014-06-02 20:44:23]

Note that I've removed one of the comments, since it refers to another comment I
couldn't find and looks stale.

https://codereview.chromium.org/305243002/diff/1/chrome/browser/ui/browser_co...
File chrome/browser/ui/browser_commands.cc (right):

https://codereview.chromium.org/305243002/diff/1/chrome/browser/ui/browser_co...
chrome/browser/ui/browser_commands.cc:316: NavigationEntry* active_entry =
On 2014/06/02 18:38:58, Peter Kasting wrote:
> Nit: Update this variable name

Done.

https://codereview.chromium.org/305243002/diff/1/chrome/browser/ui/browser_co...
chrome/browser/ui/browser_commands.cc:318: // See comment in
UpdateCommandsForTabState about why we call url().
On 2014/06/02 18:38:58, Peter Kasting wrote:
> Nit: While here: "url()" no longer seems to exist, is this referring to
> GetURL()?

There is no such comment that I can see, so it seems best to remove it due to
staleness.

https://codereview.chromium.org/305243002/diff/1/chrome/browser/ui/browser_co...
chrome/browser/ui/browser_commands.cc:1083: return
current_tab->GetController().GetLastCommittedEntry() != NULL;
On 2014/06/02 18:38:58, Peter Kasting wrote:
> Nit: Simpler:
> 
>   return current_tab && current_tab->GetController().GetLastCommittedEntry();

Done.

https://codereview.chromium.org/305243002/diff/1/chrome/browser/ui/browser_co...
chrome/browser/ui/browser_commands.cc:1158: // active entry in
view_source_contents will be the last committed entry.
On 2014/06/02 18:38:58, Peter Kasting wrote:
> This comment seems like it can be removed.

Done.

https://codereview.chromium.org/305243002/diff/1/chrome/browser/ui/browser_co...
chrome/browser/ui/browser_commands.cc:1162: NavigationEntry* active_entry =
On 2014/06/02 18:38:58, Peter Kasting wrote:
> Nit: Update this variable name.

Done.

[nasko, 2014-06-02 20:50:02]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2014-06-02 20:53:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nasko@chromium.org/305243002/20001

[commit-bot: I haz the power, 2014-06-03 09:06:14]

Change committed as 274442