Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 3052027: Partially revert r54071. (Closed)

Created:
10 years, 4 months ago by rohitrao (ping after 24h)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Partially revert r54071. I suspect that the web_contents_unittest.cc change was not reverted correctly. It is causing TabContentsTest.WebKitPrefs to fail on the 472 branch. BUG=50471 TEST=TabContentsTest.WebKitPrefs should pass again on the offical builders. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54217

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chrome/browser/tab_contents/web_contents_unittest.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rohitrao (ping after 24h)
http://codereview.chromium.org/2805089 was the original CL. http://codereview.chromium.org/3053015 was the revert on trunk. http://codereview.chromium.org/3036024 was the revert ...
10 years, 4 months ago (2010-07-29 21:40:11 UTC) #1
rohitrao (ping after 24h)
Widening a bit, because it sounds like Miranda might be on vacation. http://codereview.chromium.org/2805089 was the ...
10 years, 4 months ago (2010-07-29 22:32:15 UTC) #2
viettrungluu
It's a bit confusing, but LGTM, I think. See if the tests go green on ...
10 years, 4 months ago (2010-07-29 22:53:50 UTC) #3
John Grabowski
10 years, 4 months ago (2010-07-29 22:56:21 UTC) #4
LGTM since this appears to get things back to "before initial CL"

Powered by Google App Engine
This is Rietveld 408576698