Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: gyp/common_conditions.gypi

Issue 305193002: New file for simpler updating of Android defines. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gyp/skia_for_android_framework_defines.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/common_conditions.gypi
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi
index 75b89b7bf235a58244b14e660420fb08801645fc..6ca6632d2e2c7e928098ed1ad0cb48bf8cd3e7eb 100644
--- a/gyp/common_conditions.gypi
+++ b/gyp/common_conditions.gypi
@@ -249,6 +249,9 @@
],
['skia_android_framework', {
+ 'includes' : [
+ 'skia_for_android_framework_defines.gypi',
+ ],
'cflags': [
# Skia does not enforce this usage pattern so we disable it here to avoid
# unecessary log spew when building
@@ -320,6 +323,8 @@
'SK_ATTR_DEPRECATED=SK_NOTHING_ARG1',
'SK_SUPPORT_LEGACY_SHADER_LOCALMATRIX',
'SK_DEFAULT_GLOBAL_DISCARDABLE_MEMORY_POOL_SIZE (512 * 1024)',
scroggo 2014/05/30 17:35:12 For simplicity, I've left all of the existing flag
reed1 2014/05/30 17:39:40 if the chrome idea is sound (who knows), then the
scroggo 2014/05/30 21:03:42 Done. I left the picture ones, so as not to step o
+ # Defines from skia_for_android_framework_defines.gypi
+ '<@(skia_for_android_framework_defines)',
],
}],
« no previous file with comments | « no previous file | gyp/skia_for_android_framework_defines.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698