Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 304333002: Remove legacy Picture-recording flags from Android build (Closed)

Created:
6 years, 6 months ago by robertphillips
Modified:
6 years, 6 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove legacy Picture-recording flags from Android build Committed: https://skia.googlesource.com/skia/+/a2551ffbc740c4a276e07b321ff8f78ab87ad8b0

Patch Set 1 #

Total comments: 2

Patch Set 2 : update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M gyp/common_conditions.gypi View 1 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
robertphillips
6 years, 6 months ago (2014-05-29 18:49:54 UTC) #1
scroggo
lgtm https://codereview.chromium.org/304333002/diff/1/gyp/common_conditions.gypi File gyp/common_conditions.gypi (left): https://codereview.chromium.org/304333002/diff/1/gyp/common_conditions.gypi#oldcode312 gyp/common_conditions.gypi:312: 'SK_SUPPORT_LEGACY_PICTURE_CAN_RECORD', Does anyone else need them? Can we ...
6 years, 6 months ago (2014-05-29 18:51:21 UTC) #2
robertphillips
This is blocked right now. I made the change locally in my Android repo and ...
6 years, 6 months ago (2014-05-29 18:54:55 UTC) #3
robertphillips
https://codereview.chromium.org/304333002/diff/1/gyp/common_conditions.gypi File gyp/common_conditions.gypi (left): https://codereview.chromium.org/304333002/diff/1/gyp/common_conditions.gypi#oldcode312 gyp/common_conditions.gypi:312: 'SK_SUPPORT_LEGACY_PICTURE_CAN_RECORD', Once they are removed from here (and we're ...
6 years, 6 months ago (2014-06-02 17:21:23 UTC) #4
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 6 months ago (2014-06-02 17:21:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/304333002/1
6 years, 6 months ago (2014-06-02 17:22:00 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 17:22:02 UTC) #7
commit-bot: I haz the power
Failed to apply patch for gyp/common_conditions.gypi: While running git apply --index -p1; error: patch failed: ...
6 years, 6 months ago (2014-06-02 17:22:03 UTC) #8
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 6 months ago (2014-06-02 19:03:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/304333002/20001
6 years, 6 months ago (2014-06-02 19:04:09 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 19:09:33 UTC) #11
Message was sent while issue was closed. 
Change committed as a2551ffbc740c4a276e07b321ff8f78ab87ad8b0

Powered by Google App Engine
This is Rietveld 408576698