New file for simpler updating of Android defines.

New file for simpler updating of Android defines.

When building Skia for the Android framework, we will now read a
file which only includes defines. This will make it easier for
people deprecating APIs to add the guard to Android.

Committed: http://code.google.com/p/skia/source/detail?r=15013

[scroggo, 2014-05-30 17:35:12]

https://codereview.chromium.org/305193002/diff/1/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/305193002/diff/1/gyp/common_conditions.gypi#n...
gyp/common_conditions.gypi:325: 'SK_DEFAULT_GLOBAL_DISCARDABLE_MEMORY_POOL_SIZE
(512 * 1024)',
For simplicity, I've left all of the existing flags here. It appears the
analogous file for chrome is only for temporary flags. Should the android
framework one be used in the same way? (Or for all flags?) Should I move the
appropriate flags to skia_for_android_framework_defines.gypi?

[reed1, 2014-05-30 17:39:40]

https://codereview.chromium.org/305193002/diff/1/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/305193002/diff/1/gyp/common_conditions.gypi#n...
gyp/common_conditions.gypi:325: 'SK_DEFAULT_GLOBAL_DISCARDABLE_MEMORY_POOL_SIZE
(512 * 1024)',
On 2014/05/30 17:35:12, scroggo wrote:
> For simplicity, I've left all of the existing flags here. It appears the
> analogous file for chrome is only for temporary flags. Should the android
> framework one be used in the same way? (Or for all flags?) Should I move the
> appropriate flags to skia_for_android_framework_defines.gypi?

if the chrome idea is sound (who knows), then the new file is for defines that
are just being staged (i.e. marked deprecated). 

Thus we could move any of the SUPPORT_LEGACY flags (at least) into the new file.

[scroggo, 2014-05-30 21:03:42]

https://codereview.chromium.org/305193002/diff/1/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/305193002/diff/1/gyp/common_conditions.gypi#n...
gyp/common_conditions.gypi:325: 'SK_DEFAULT_GLOBAL_DISCARDABLE_MEMORY_POOL_SIZE
(512 * 1024)',
On 2014/05/30 17:39:40, reed1 wrote:
> On 2014/05/30 17:35:12, scroggo wrote:
> > For simplicity, I've left all of the existing flags here. It appears the
> > analogous file for chrome is only for temporary flags. Should the android
> > framework one be used in the same way? (Or for all flags?) Should I move the
> > appropriate flags to skia_for_android_framework_defines.gypi?
> 
> if the chrome idea is sound (who knows), then the new file is for defines that
> are just being staged (i.e. marked deprecated). 
> 
> Thus we could move any of the SUPPORT_LEGACY flags (at least) into the new
file.

Done. I left the picture ones, so as not to step on Robert:
https://codereview.chromium.org/304333002/

[reed1, 2014-05-30 21:45:18]

lgtm

[scroggo, 2014-05-30 21:45:49]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2014-05-30 21:47:03]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/scroggo@google.com/305193002/20001

[commit-bot: I haz the power, 2014-05-30 21:53:04]

Change committed as 15013