Issue 3047046: Fix Valgrind malloc interceptors....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3047046: Fix Valgrind malloc interceptors.... (Closed)

Created:
10 years, 4 months ago by Alexander Potapenko

Modified:
9 years, 6 months ago

Reviewers:
Timur Iskhodzhanov, willchan no longer on Chromium

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/valgrind/

Visibility:
Public.

Description

Fix Valgrind malloc interceptors. Up to r49172 Valgrind used to intercept the custom allocation functions with soname=NONE (a). This caused some tests to fail under Valgrind when built with TCMalloc (see bug 31951) In r49172 Valgrind stopped intercepting the custom allocators and switched to tc_{malloc,free,new,...} functions declared by TCMalloc (b). This is a more correct approach to handle TCMalloc allocation, but it was broken because tc_* functions were implemented as libc allocation functions aliases (see bug 49757) The new binaries should handle both (a) and (b) and fix both bugs. BUG=49757, 31951 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55206

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+167 lines, -23 lines)			Patch
M	binaries/linux_x64/lib/valgrind/vgpreload_memcheck-amd64-linux.so	View		Binary file		0 comments	Download
M	binaries/linux_x64/lib/valgrind/vgpreload_memcheck-x86-linux.so	View		Binary file		0 comments	Download
M	binaries/linux_x86/lib/valgrind/vgpreload_memcheck-x86-linux.so	View		Binary file		0 comments	Download
M	scripts/intercept_tcmalloc.patch	View	1	2 chunks	+167 lines, -23 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years, 4 months ago (2010-08-04 15:54:38 UTC) #1

Folks, could you please take a look?
I'm going to land this tomorrow morning (MSD) and monitor the bots.

Expand Messages | Collapse Messages