Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(390)

Issue 3047046: Fix Valgrind malloc interceptors.... (Closed)

Created:
10 years, 5 months ago by Alexander Potapenko
Modified:
9 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix Valgrind malloc interceptors. Up to r49172 Valgrind used to intercept the custom allocation functions with soname=NONE (a). This caused some tests to fail under Valgrind when built with TCMalloc (see bug 31951) In r49172 Valgrind stopped intercepting the custom allocators and switched to tc_{malloc,free,new,...} functions declared by TCMalloc (b). This is a more correct approach to handle TCMalloc allocation, but it was broken because tc_* functions were implemented as libc allocation functions aliases (see bug 49757) The new binaries should handle both (a) and (b) and fix both bugs. BUG=49757, 31951 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55206

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -23 lines) Patch
M binaries/linux_x64/lib/valgrind/vgpreload_memcheck-amd64-linux.so View Binary file 0 comments Download
M binaries/linux_x64/lib/valgrind/vgpreload_memcheck-x86-linux.so View Binary file 0 comments Download
M binaries/linux_x86/lib/valgrind/vgpreload_memcheck-x86-linux.so View Binary file 0 comments Download
M scripts/intercept_tcmalloc.patch View 1 2 chunks +167 lines, -23 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Alexander Potapenko
10 years, 5 months ago (2010-08-04 15:54:38 UTC) #1
Folks, could you please take a look?
I'm going to land this tomorrow morning (MSD) and monitor the bots.

Powered by Google App Engine
This is Rietveld 408576698