Issue 304603005: Add content renderer to the GN build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 304603005: Add content renderer to the GN build (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
scottmg

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add content renderer to the GN build Also adds ui/native_theme, third_party/npapi, and some required mojo stuff to make it build. Reland of https://codereview.chromium.org/299113002 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273270

Patch Set 1 #

Patch Set 2 : fix #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+548 lines, -256 lines)			Patch
M	BUILD.gn	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	build/config/BUILD.gn	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	build/config/features.gni	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/BUILD.gn	View		3 chunks	+27 lines, -1 line	0 comments	Download
M	content/common/BUILD.gn	View		4 chunks	+8 lines, -4 lines	0 comments	Download
M	content/content_renderer.gypi	View	1	4 chunks	+257 lines, -241 lines	0 comments	Download
M	content/public/common/BUILD.gn	View		1 chunk	+1 line, -2 lines	0 comments	Download
A	content/public/renderer/BUILD.gn	View		1 chunk	+30 lines, -0 lines	0 comments	Download
A	content/renderer/BUILD.gn	View	1	1 chunk	+182 lines, -0 lines	0 comments	Download
A +	content/renderer/renderer.gni	View		1 chunk	+5 lines, -5 lines	0 comments	Download
A +	mojo/public/interfaces/shell/BUILD.gn	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A	third_party/npapi/BUILD.gn	View		1 chunk	+24 lines, -0 lines	0 comments	Download
M	ui/native_theme/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

The difference from the previous alandings is in patch 1->2 diff. I messed up the ...

6 years, 6 months ago (2014-05-28 01:19:05 UTC) #1

brettw

6 years, 6 months ago (2014-05-28 16:51:48 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r273270 (presubmit successful).

Expand Messages | Collapse Messages