Issue 299113002: Add content renderer to the GN build

Issue 299113002: Add content renderer to the GN build (Closed)

Created:
6 years, 7 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
scottmg

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add content renderer to the GN build Also adds ui/native_theme, third_party/npapi, and some required mojo stuff to make it build. BUG= R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273079

Patch Set 5 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+531 lines, -256 lines)			Patch
M	BUILD.gn	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	build/config/BUILD.gn	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	build/config/features.gni	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/BUILD.gn	View	1 2 3	3 chunks	+27 lines, -1 line	0 comments	Download
M	content/common/BUILD.gn	View	1 2 3	4 chunks	+8 lines, -4 lines	0 comments	Download
M	content/content_renderer.gypi	View	1 2 3 4	4 chunks	+246 lines, -241 lines	0 comments	Download
M	content/public/common/BUILD.gn	View		1 chunk	+1 line, -2 lines	0 comments	Download
A	content/public/renderer/BUILD.gn	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download
A	content/renderer/BUILD.gn	View	1 2 3	1 chunk	+176 lines, -0 lines	0 comments	Download
A +	content/renderer/renderer.gni	View		1 chunk	+5 lines, -5 lines	0 comments	Download
A +	mojo/public/interfaces/shell/BUILD.gn	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
A	third_party/npapi/BUILD.gn	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
M	ui/native_theme/BUILD.gn	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm https://codereview.chromium.org/299113002/diff/40001/content/content_renderer.gypi File content/content_renderer.gypi (left): https://codereview.chromium.org/299113002/diff/40001/content/content_renderer.gypi#oldcode779 content/content_renderer.gypi:779: 'renderer/media/pepper_platform_video_decoder.cc', this was just silently ignored before?

6 years, 7 months ago (2014-05-23 21:57:02 UTC) #2

brettw

https://codereview.chromium.org/299113002/diff/40001/content/content_renderer.gypi File content/content_renderer.gypi (left): https://codereview.chromium.org/299113002/diff/40001/content/content_renderer.gypi#oldcode779 content/content_renderer.gypi:779: 'renderer/media/pepper_platform_video_decoder.cc', On 2014/05/23 21:57:02, scottmg wrote: > this was ...

6 years, 7 months ago (2014-05-24 04:33:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r273079.

Expand Messages | Collapse Messages