Chromium Code Reviews

Issue 299113002: Add content renderer to the GN build (Closed)

Created:
6 years, 7 months ago by brettw
Modified:
6 years, 6 months ago
Reviewers:
scottmg
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add content renderer to the GN build Also adds ui/native_theme, third_party/npapi, and some required mojo stuff to make it build. BUG= R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273079

Patch Set 1 #

Patch Set 2 : compiles now #

Patch Set 3 : widevine fix #

Total comments: 2

Patch Set 4 : merge #

Patch Set 5 : #

Unified diffs Side-by-side diffs Stats (+531 lines, -256 lines)
M BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments
M build/config/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments
M build/config/features.gni View 1 chunk +4 lines, -0 lines 0 comments
M content/BUILD.gn View 3 chunks +27 lines, -1 line 0 comments
M content/common/BUILD.gn View 4 chunks +8 lines, -4 lines 0 comments
M content/content_renderer.gypi View 4 chunks +246 lines, -241 lines 0 comments
M content/public/common/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments
A content/public/renderer/BUILD.gn View 1 chunk +30 lines, -0 lines 0 comments
A content/renderer/BUILD.gn View 1 chunk +176 lines, -0 lines 0 comments
A + content/renderer/renderer.gni View 1 chunk +5 lines, -5 lines 0 comments
A + mojo/public/interfaces/shell/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments
A third_party/npapi/BUILD.gn View 1 chunk +24 lines, -0 lines 0 comments
M ui/native_theme/BUILD.gn View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 4 (0 generated)
brettw
6 years, 7 months ago (2014-05-23 17:58:13 UTC) #1
scottmg
lgtm https://codereview.chromium.org/299113002/diff/40001/content/content_renderer.gypi File content/content_renderer.gypi (left): https://codereview.chromium.org/299113002/diff/40001/content/content_renderer.gypi#oldcode779 content/content_renderer.gypi:779: 'renderer/media/pepper_platform_video_decoder.cc', this was just silently ignored before?
6 years, 7 months ago (2014-05-23 21:57:02 UTC) #2
brettw
https://codereview.chromium.org/299113002/diff/40001/content/content_renderer.gypi File content/content_renderer.gypi (left): https://codereview.chromium.org/299113002/diff/40001/content/content_renderer.gypi#oldcode779 content/content_renderer.gypi:779: 'renderer/media/pepper_platform_video_decoder.cc', On 2014/05/23 21:57:02, scottmg wrote: > this was ...
6 years, 7 months ago (2014-05-24 04:33:50 UTC) #3
brettw
6 years, 6 months ago (2014-05-28 00:03:10 UTC) #4
Message was sent while issue was closed. 
Committed patchset #5 manually as r273079.

Powered by Google App Engine