Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 304533003: [fsp] Rename has_next to has_more. (Closed)

Created:
6 years, 7 months ago by mtomasz
Modified:
6 years, 6 months ago
Reviewers:
benwells, kinaba
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tzik, nhiroki, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Visibility:
Public.

Description

[fsp] Rename has_next to has_more. For consistency, has_next is changed to has_more. Also, has_more is easier to understand in providing extensions context. TEST=browser_tests, unit_test: *FileSystemProvider* BUG=373165 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274217

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -100 lines) Patch
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_system_provider/provider_function.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/close_file.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/close_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/close_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/get_metadata.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/get_metadata.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/get_metadata_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/open_file.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/open_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/operation.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/read_directory.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/read_directory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/read_file.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/read_file.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/unmount.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/unmount.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc View 1 1 chunk +185 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/request_manager.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/request_manager.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/request_manager_unittest.cc View 1 9 chunks +23 lines, -23 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider.idl View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider_internal.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/read_directory/test.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/read_file/test.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 38 (0 generated)
mtomasz
@kinaba: PTAL. This is a string replace has_next -> has_more and hasNext -> hasMore. Thanks.
6 years, 7 months ago (2014-05-27 07:23:41 UTC) #1
kinaba
lgtm https://codereview.chromium.org/304533003/diff/1/chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc File chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc (right): https://codereview.chromium.org/304533003/diff/1/chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc#newcode200 chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc:200: if (current_offset > kFakeFileSize || !current_length) { Not ...
6 years, 7 months ago (2014-05-27 07:33:21 UTC) #2
mtomasz
https://codereview.chromium.org/304533003/diff/1/chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc File chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc (right): https://codereview.chromium.org/304533003/diff/1/chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc#newcode200 chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc:200: if (current_offset > kFakeFileSize || !current_length) { On 2014/05/27 ...
6 years, 7 months ago (2014-05-27 07:48:34 UTC) #3
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 7 months ago (2014-05-27 07:48:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/304533003/1
6 years, 7 months ago (2014-05-27 07:48:51 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-27 10:56:04 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 10:59:34 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/69837)
6 years, 7 months ago (2014-05-27 10:59:35 UTC) #8
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 7 months ago (2014-05-27 23:22:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/304533003/1
6 years, 7 months ago (2014-05-27 23:23:27 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 7 months ago (2014-05-28 00:22:10 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-28 00:28:50 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/70007)
6 years, 7 months ago (2014-05-28 00:28:50 UTC) #13
mtomasz
@benwells: PTAL at IDL. Thanks.
6 years, 7 months ago (2014-05-28 02:03:22 UTC) #14
benwells
lgtm
6 years, 6 months ago (2014-05-28 06:21:48 UTC) #15
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 6 months ago (2014-05-28 06:22:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/304533003/1
6 years, 6 months ago (2014-05-28 06:22:17 UTC) #17
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-05-28 06:28:18 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-28 06:31:19 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/70062)
6 years, 6 months ago (2014-05-28 06:31:19 UTC) #20
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 6 months ago (2014-05-29 01:04:39 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/304533003/1
6 years, 6 months ago (2014-05-29 01:05:39 UTC) #22
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 01:10:44 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 01:15:05 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/70297)
6 years, 6 months ago (2014-05-29 01:15:06 UTC) #25
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 6 months ago (2014-05-29 02:32:38 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/304533003/1
6 years, 6 months ago (2014-05-29 02:34:04 UTC) #27
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 02:43:33 UTC) #28
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 02:55:03 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/70319)
6 years, 6 months ago (2014-05-29 02:55:04 UTC) #30
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 6 months ago (2014-06-02 00:49:41 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/304533003/1
6 years, 6 months ago (2014-06-02 00:49:57 UTC) #32
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-02 00:52:19 UTC) #33
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 00:54:28 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/70933)
6 years, 6 months ago (2014-06-02 00:54:28 UTC) #35
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 6 months ago (2014-06-02 08:47:27 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/304533003/20001
6 years, 6 months ago (2014-06-02 08:48:08 UTC) #37
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 12:45:47 UTC) #38
Message was sent while issue was closed.
Change committed as 274217

Powered by Google App Engine
This is Rietveld 408576698